Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/325858 )

Change subject: Don't access protected SpecialPage::getLinkRenderer()
......................................................................

Don't access protected SpecialPage::getLinkRenderer()

It should be public but can fix that later...

Follows-up f4ddf5dd2.

Change-Id: Ia1f84226859e0ac170f4697cf40d682e36850712
---
M AbuseFilter.hooks.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AbuseFilter 
refs/changes/58/325858/1

diff --git a/AbuseFilter.hooks.php b/AbuseFilter.hooks.php
index 5e32e1a..2254f18 100644
--- a/AbuseFilter.hooks.php
+++ b/AbuseFilter.hooks.php
@@ -1,6 +1,7 @@
 <?php
 
 use MediaWiki\Auth\AuthManager;
+use MediaWiki\MediaWikiServices;
 
 class AbuseFilterHooks {
        public static $successful_action_vars = false;
@@ -696,13 +697,12 @@
        public static function onContributionsToolLinks( $id, $nt, &$tools, 
SpecialPage $sp = null ) {
                if ( $sp ) {
                        $context = $sp->getContext();
-                       $linkRenderer = $sp->getLinkRenderer();
                } else {
                        // Fallback to main context
                        $context = RequestContext::getMain();
-                       $linkRenderer = 
MediaWikiServices::getInstance()->getLinkRenderer();
                }
                if ( $context->getUser()->isAllowed( 'abusefilter-log' ) ) {
+                       $linkRenderer = 
MediaWikiServices::getInstance()->getLinkRenderer();
                        $tools[] = $linkRenderer->makeLink(
                                SpecialPage::getTitleFor( 'AbuseLog' ),
                                $context->msg( 'abusefilter-log-linkoncontribs' 
)->text(),

-- 
To view, visit https://gerrit.wikimedia.org/r/325858
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1f84226859e0ac170f4697cf40d682e36850712
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to