Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/325826 )
Change subject: gerrit: Fix jenkins comments to pretty them again ...................................................................... gerrit: Fix jenkins comments to pretty them again Currently we use regex to try and match specific comments to make them look nicer (ci) See http://gerrit-test.wmflabs.org/gerrit/#/c/17/ (jenkins comments) to know what im talking about prettyer. Currently we use have a links like <a href="http://gerrit-jenkins.wmflabs.org/job/debian-glue-non-voting/131/console"; target="_blank">debian-glue-non-voting</a> but that is now changed too <a href="https://integration.wikimedia.org/ci/job/operations-puppet-tox-jessie/10427/console"; target="_blank" rel="nofollow"debian-glue-non-voting</a> we have to update the regex to use the added rel="nofollow" otherwise the regex wont match thus no more pretty links. Im not 100% this will fix it but it looks like it will. Change-Id: I5d00e920c038024cf4de6241a5b4b0963a18cafa --- M modules/gerrit/templates/gerrit.config.erb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Paladox: Looks good to me, but someone else must approve Hashar: Looks good to me, but someone else must approve jenkins-bot: Verified Dzahn: Looks good to me, approved diff --git a/modules/gerrit/templates/gerrit.config.erb b/modules/gerrit/templates/gerrit.config.erb index 11a238a..7685ca3 100644 --- a/modules/gerrit/templates/gerrit.config.erb +++ b/modules/gerrit/templates/gerrit.config.erb @@ -119,7 +119,7 @@ match = "\\b([aA]nalytics\\s*[:-]?\\s*[cC]ard|[cC]ard\\s*[:-]?\\s*[aA]nalytics)\\s*\\#?\\s*(\\d+)\\b" link = https://wikimedia.mingle.thoughtworks.com/projects/analytics/cards/$2 [commentlink "ci-test-result"] - match = <li>([^ ]+) (<a href=\"https://integration\\.wikimedia\\.org/ci/[a-zA-Z0-9/_.-]+\"; target=\"_blank\">)[^<]+</a> : ([a-zA-Z_]+)([^<]*)</li> + match = <li>([^ ]+) (<a href=\"https://integration\\.wikimedia\\.org/ci/[a-zA-Z0-9/_.-]+\"; target=\"_blank\" rel=\"nofollow\">)[^<]+</a> : ([a-zA-Z_]+)([^<]*)</li> html = <li class=\"ci_comment_test\"><span class=\"ci_comment_test_name\">$2$1</a></span> <span class=\"ci_comment_test_result\"><span class=\"ci_result_$3\">$3</span>$4</span></li> [commentlink "its-phabricator"] # $1 must hold the bug number because of the notification bots that are using this. -- To view, visit https://gerrit.wikimedia.org/r/325826 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d00e920c038024cf4de6241a5b4b0963a18cafa Gerrit-PatchSet: 7 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Paladox <[email protected]> Gerrit-Reviewer: Chad <[email protected]> Gerrit-Reviewer: Dzahn <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: Paladox <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
