Marostegui has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/326124 )

Change subject: check_mariadb.pl: Fixed small display issue
......................................................................

check_mariadb.pl: Fixed small display issue

The current regular expression was showing the following on Icinga:

CRITICAL slave_sql_state Slave_SQL_Running: No, Errno: 1062, Errmsg:
Error 'Duplicate entry 'MANUALLY REMOVED' for key 'PRIMARY'' on query. Default
database: 'commonswiki'. Query: [snipped]2

The value "2" wasn't being filtered.
This commit has been tested on dbstore1001 (which is having that issue)
and it displays the following instead:

CRITICAL slave_sql_state Slave_SQL_Running: No, Errno: 1062, Errmsg:
Error 'Duplicate entry 'MANUALLY REMOVED' for key 'PRIMARY'' on query. Default
database: 'commonswiki'. [Query snipped]

Bug: T152766
Change-Id: Ie14d1f963bae7d70b642cc6e9278836c2c330cd5
---
M modules/icinga/files/check_mariadb.pl
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/24/326124/1

diff --git a/modules/icinga/files/check_mariadb.pl 
b/modules/icinga/files/check_mariadb.pl
index 489347a..79398f3 100755
--- a/modules/icinga/files/check_mariadb.pl
+++ b/modules/icinga/files/check_mariadb.pl
@@ -153,7 +153,7 @@
                exit($EOK);
        }
        # sanitize the query for icinga:
-       $status->{Last_SQL_Error} =~ s/Query:\s+'(.*)'/Query: [snipped]/;
+    $status->{Last_SQL_Error} =~ s/Query.*/[Query snipped]/;
 
        # Both SQL and IO threads running? OK
        if ($status->{Slave_SQL_Running} eq "Yes") {

-- 
To view, visit https://gerrit.wikimedia.org/r/326124
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie14d1f963bae7d70b642cc6e9278836c2c330cd5
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Marostegui <maroste...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to