jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/326157 )
Change subject: Follow-up Iaa41c49e: Don't assume source dialogs have a fragment ...................................................................... Follow-up Iaa41c49e: Don't assume source dialogs have a fragment Change-Id: Ife26d229fba043ae93610ee35efeb6d500b81a07 --- M src/ui/actions/ve.ui.WindowAction.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: jenkins-bot: Verified Jforrester: Looks good to me, approved diff --git a/src/ui/actions/ve.ui.WindowAction.js b/src/ui/actions/ve.ui.WindowAction.js index fe858af..3fd3898 100644 --- a/src/ui/actions/ve.ui.WindowAction.js +++ b/src/ui/actions/ve.ui.WindowAction.js @@ -136,7 +136,7 @@ if ( data.strippedSequence && !( closedData && closedData.action ) ) { surface.getModel().undo(); } - if ( sourceMode && fragment.getSurface().hasBeenModified() ) { + if ( sourceMode && fragment && fragment.getSurface().hasBeenModified() ) { originalFragment.insertDocument( fragment.getDocument() ); } surface.getView().emit( 'position' ); -- To view, visit https://gerrit.wikimedia.org/r/326157 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife26d229fba043ae93610ee35efeb6d500b81a07 Gerrit-PatchSet: 2 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits