jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/326351 )

Change subject: Cleaned "Article::getContent" deprecated in MediaWiki 1.21
......................................................................


Cleaned "Article::getContent" deprecated in MediaWiki 1.21

"Article::getContent" is deprecated - cleaned code

Bug: T151973
Change-Id: Ica59317c4c16adb0784ab8285aaec99bd6824551
---
M BreadCrumbs2.class.php
1 file changed, 5 insertions(+), 12 deletions(-)

Approvals:
  Reedy: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/BreadCrumbs2.class.php b/BreadCrumbs2.class.php
index e6cf462..f557fc5 100644
--- a/BreadCrumbs2.class.php
+++ b/BreadCrumbs2.class.php
@@ -222,20 +222,13 @@
         * @return string|null
         */
        function getPageText( Title $title ) {
-               if ( method_exists( 'WikiPage', 'getContent' ) ) {
-                       // MW 1.21+
-                       $wikiPage = new WikiPage( $title );
-                       $content = $wikiPage->getContent();
+               $wikiPage = new WikiPage( $title );
+               $content = $wikiPage->getContent();
 
-                       if ( $content !== null ) {
-                               return $content->getNativeData();
-                       } else {
-                               return null;
-                       }
+               if ( $content !== null ) {
+                       return $content->getNativeData();
                } else {
-                       // MW <= 1.20
-                       $article = new Article( $title );
-                       return $article->getContent();
+                       return null;
                }
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/326351
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ica59317c4c16adb0784ab8285aaec99bd6824551
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/BreadCrumbs2
Gerrit-Branch: master
Gerrit-Owner: Filip <r...@protonmail.com>
Gerrit-Reviewer: Niharika29 <niharikakohl...@gmail.com>
Gerrit-Reviewer: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to