Bmansurov has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/326526 )
Change subject: Remove redundant "prefix" from ResourceLoaderImageModule modules
......................................................................
Remove redundant "prefix" from ResourceLoaderImageModule modules
There is no need for the "prefix" key when either "selector" or
"selectorWithVariant"/"selectorWithoutVariant" is used. [1]
Also remove the obsolete ".mw-ui-icon-{name}:before" selector
from "mobile.mainMenu.icons".
[1] https://doc.wikimedia.org/mediawiki-core/master/php
/classResourceLoaderImageModule.html#aa247012cd5dcbdd0bcc2b511008ff26a
Bug: T152732
Change-Id: I693c29427de3afea3c41178de54fbb7ed669f2fe
---
M extension.json
1 file changed, 1 insertion(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/26/326526/1
diff --git a/extension.json b/extension.json
index b808d8e..edaa83f 100644
--- a/extension.json
+++ b/extension.json
@@ -166,7 +166,6 @@
},
"skins.minerva.icons.images": {
"class": "ResourceLoaderImageModule",
- "prefix": "mw-ui",
"selector": ".mw-ui-icon-{name}:before",
"images": {
"notifications":
"resources/skins.minerva.icons.images/bell.svg",
@@ -181,7 +180,6 @@
"selectorWithoutVariant": ".mw-ui-icon-{name}:before",
"selectorWithVariant":
".mw-ui-icon-{name}-{variant}:before",
"class": "ResourceLoaderImageModule",
- "prefix": "mw-ui",
"variants": {
"gray": {
"color": "#BBB",
@@ -201,7 +199,6 @@
"selectorWithoutVariant": ".mw-ui-icon-{name}:before",
"selectorWithVariant":
".mw-ui-icon-{name}-{variant}:before",
"class": "ResourceLoaderImageModule",
- "prefix": "mw-ui",
"variants": {
"gray": {
"color": "#BBB",
@@ -218,7 +215,6 @@
},
"mobile.issues.images": {
"class": "ResourceLoaderImageModule",
- "prefix": "mw-ui",
"selector": ".mw-ui-icon-{name}:before",
"images": {
"cleanup":
"resources/mobile.issues.images/blue-triangle.svg",
@@ -227,7 +223,6 @@
},
"mobile.toc.images": {
"class": "ResourceLoaderImageModule",
- "prefix": "mw-ui",
"selector": ".mw-ui-icon-{name}:before",
"images": {
"toc":
"resources/mobile.toc.images/contents-ltr.svg"
@@ -235,7 +230,6 @@
},
"mobile.references.images": {
"class": "ResourceLoaderImageModule",
- "prefix": "mw-ui",
"selector": ".mw-ui-icon-{name}:before",
"images": {
"citation":
"resources/mobile.references.images/cite.svg"
@@ -243,7 +237,6 @@
},
"skins.minerva.icons.images.scripts": {
"class": "ResourceLoaderImageModule",
- "prefix": "mw-ui",
"selector": ".mw-ui-icon-{name}:before",
"position": "bottom",
"images": {
@@ -276,7 +269,6 @@
},
"skins.minerva.userpage.icons": {
"class": "ResourceLoaderImageModule",
- "prefix": "mw-ui",
"selector": ".mw-ui-icon-{name}:before",
"images": {
"talk":
"resources/skins.minerva.userpage.icons/talk.svg"
@@ -354,8 +346,7 @@
},
"mobile.mainMenu.icons": {
"class": "ResourceLoaderImageModule",
- "selector":
".mw-ui-icon-{name}:before,.mw-ui-icon-mf-{name}:before",
- "prefix": "mw-ui",
+ "selector": ".mw-ui-icon-mf-{name}:before",
"images": {
"anonymous":
"resources/mobile.mainMenu.icons/anonymous.svg",
"home":
"resources/mobile.mainMenu.icons/home.svg",
@@ -756,7 +747,6 @@
},
"mobile.search.images": {
"class": "ResourceLoaderImageModule",
- "prefix": "mw-ui",
"selector": ".mw-ui-icon-{name}:before",
"images": {
"clear":
"resources/mobile.search.images/clear.svg"
@@ -913,7 +903,6 @@
"class": "ResourceLoaderImageModule",
"selectorWithVariant":
".mw-ui-icon-{name}-{variant}:before",
"selectorWithoutVariant": ".mw-ui-icon-{name}:before",
- "prefix": "mw-ui",
"variants": {
"invert": {
"color": "#FFFFFF",
--
To view, visit https://gerrit.wikimedia.org/r/326526
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I693c29427de3afea3c41178de54fbb7ed669f2fe
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <bmansu...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
