Pwirth has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/326938 )
Change subject: BSReview: Yearly mail fixes ...................................................................... BSReview: Yearly mail fixes => Needs cherry-pick to REL1_27 and master Change-Id: I7e04f3b71e8c0bba7b7ef435da42cf21328e27c5 --- M Review/Review.class.php 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions refs/changes/38/326938/1 diff --git a/Review/Review.class.php b/Review/Review.class.php index eb16090..9195716 100644 --- a/Review/Review.class.php +++ b/Review/Review.class.php @@ -1335,6 +1335,9 @@ ); } } else { + if ( $oReviewProcess->isSequential() && !$oReviewProcess->isFinished() ) { + $oReview->emailNotifyNextUsers( $oReviewProcess ); + } BSNotifications::notify( 'bs-review-accept', $oUser, @@ -1372,7 +1375,12 @@ // Let flagged revision know that it's all goooooood (or not approved) $bResult = true; wfRunHooks( 'checkPageIsReviewable', array( $oTitle, &$bResult ) ); - if ( $bResult && $oReviewProcess->isFinished() == 'status' && $oUser->isAllowed( 'review' ) ) { + //all autorevie related stuff should be moved to FlaggedRevsConnector + //send autoflag mail only when it is acitvated + $bAutoReview = class_exists( 'FlaggedRevsConnector' ) + && BsConfig::get('MW::FlaggedRevsConnector::autoReview') === true + ; + if ( $bResult && $oReviewProcess->isFinished() == 'status' && $bAutoReview ) { BSNotifications::notify( 'bs-review-finish-and-autoflag', $oUser, -- To view, visit https://gerrit.wikimedia.org/r/326938 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7e04f3b71e8c0bba7b7ef435da42cf21328e27c5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions Gerrit-Branch: REL1_23 Gerrit-Owner: Pwirth <wi...@hallowelt.biz> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits