Dzahn has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/326232 )
Change subject: Enable Parsoid's linter on ruthenium
......................................................................
Enable Parsoid's linter on ruthenium
* Clear out some obsolete configs while we're there.
Change-Id: I7c5f5696e520f4bbbcfaf0560201a1f0bb7b9b04
---
M modules/testreduce/templates/parsoid-rt-client.config.js.erb
M modules/testreduce/templates/parsoid-rt-client.rttest.localsettings.js.erb
2 files changed, 7 insertions(+), 17 deletions(-)
Approvals:
Subramanya Sastry: Looks good to me, but someone else must approve
Mobrovac: Looks good to me, but someone else must approve
jenkins-bot: Verified
Dzahn: Looks good to me, approved
diff --git a/modules/testreduce/templates/parsoid-rt-client.config.js.erb
b/modules/testreduce/templates/parsoid-rt-client.config.js.erb
index e15e987..4052c1d 100644
--- a/modules/testreduce/templates/parsoid-rt-client.config.js.erb
+++ b/modules/testreduce/templates/parsoid-rt-client.config.js.erb
@@ -21,11 +21,6 @@
// Talk to the existing Parsoid service.
// No need to spin up our own private Parsoid
service.
parsoidURL: 'http://localhost:8142',
-
- // FIXME: Weird! rt-testing code, for some
reason, uses the Parsoid config too.
- // It is posting requests to Parsoid to run
tests, so not sure why it needs the
- // config. Refactor that code to eliminate this
dependency, if possible.
- parsoidConfig:
'/srv/deployment/parsoid/deploy/src/tests/testreduce/parsoid-rt-client.rttest.localsettings.js',
},
runTest:
require('/srv/deployment/parsoid/deploy/src/tests/testreduce/rtTestWrapper.js').runRoundTripTest,
diff --git
a/modules/testreduce/templates/parsoid-rt-client.rttest.localsettings.js.erb
b/modules/testreduce/templates/parsoid-rt-client.rttest.localsettings.js.erb
index bcf2468..c474be2 100644
--- a/modules/testreduce/templates/parsoid-rt-client.rttest.localsettings.js.erb
+++ b/modules/testreduce/templates/parsoid-rt-client.rttest.localsettings.js.erb
@@ -11,15 +11,6 @@
// Point at WMF's wikis
parsoidConfig.loadWMF = true;
- // The URL of your MediaWiki API endpoint.
- if (process.env.PARSOID_MOCKAPI_URL) {
- parsoidConfig.setMwApi({
- prefix: 'customwiki',
- domain: 'customwiki',
- uri: process.env.PARSOID_MOCKAPI_URL,
- });
- }
-
// Use the API backends directly without hitting the text varnishes.
// API requests are not cacheable anyway.
parsoidConfig.defaultAPIProxyURI = 'http://api.svc.<%=
scope.lookupvar('::mw_primary') %>.wmnet';
@@ -27,11 +18,15 @@
// Turn on the batching API
parsoidConfig.useBatchAPI = true;
- // Use selective serialization (default false)
+ // Use selective serialization
parsoidConfig.useSelser = true;
- // The URL of your LintBridge API endpoint
- // parsoidConfig.linterAPI = 'http://lintbridge.wmflabs.org/add';
+ // Enabled the linting code
+ parsoidConfig.linting = true;
+ // at a low sampling rate
+ parsoidConfig.linterAPISampling = 1000; // 0.1%
+ // and send it to logs
+ parsoidConfig.linterSendAPI = false;
// Set rtTestMode to true for round-trip testing
parsoidConfig.rtTestMode = true;
--
To view, visit https://gerrit.wikimedia.org/r/326232
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c5f5696e520f4bbbcfaf0560201a1f0bb7b9b04
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Arlolra <abrea...@wikimedia.org>
Gerrit-Reviewer: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: Subramanya Sastry <ssas...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
