VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/327039 )

Change subject: HTMLForm Flatlist: Improve margin
......................................................................

HTMLForm Flatlist: Improve margin

Flatlists need special margin treatment to be aligned with OOjs UI
form elements.

Change-Id: Ice666e54e440f97d177580ac258dfbed1577da0a
---
M resources/src/mediawiki/htmlform/ooui.styles.css
1 file changed, 19 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/39/327039/1

diff --git a/resources/src/mediawiki/htmlform/ooui.styles.css 
b/resources/src/mediawiki/htmlform/ooui.styles.css
index 40f4f52..36d1cc8 100644
--- a/resources/src/mediawiki/htmlform/ooui.styles.css
+++ b/resources/src/mediawiki/htmlform/ooui.styles.css
@@ -1,7 +1,17 @@
 /* OOUIHTMLForm styles */
 
+/*
+ * Calculation of margins, compare OOjs UI MediaWiki theme's common.less
+ *
+ * @oo-ui-font-size-browser: 16; // assumed browser default of `16px`
+ * @vector-font-size-default: 0.875em; // equals `14px` at browser default of 
`16px`
+ *
+ * Instead of `1.25em` in the guideline, we go for `15px`/`1.171875em`
+ * 15 / @oo-ui-font-size-browser / @vector-font-size-default equals 
`1.0714285714em`≈`15px` at base `font-size: 14px`
+ */
+
 .mw-htmlform-ooui .mw-htmlform-submit-buttons {
-       margin-top: 1em;
+       margin-top: 1.071em;
 }
 
 .mw-htmlform-ooui .mw-htmlform-field-HTMLCheckMatrix,
@@ -15,11 +25,17 @@
        width: 39%;
 }
 
-/* Flatlist styling for PHP widgets... */
+/* Flatlist */
+.mw-htmlform-flatlist {
+       margin-top: 1.071em;
+}
+
+/* PHP widgets... */
 .mw-htmlform-flatlist .oo-ui-fieldLayout-align-inline,
-/* ...and for JS widgets */
+/* JS widgets */
 .mw-htmlform-flatlist .oo-ui-radioOptionWidget,
 .mw-htmlform-flatlist .oo-ui-checkboxMultioptionWidget {
        display: inline-block;
+       margin-top: 0;
        margin-right: 1em;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/327039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice666e54e440f97d177580ac258dfbed1577da0a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to