jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/327120 )
Change subject: Fix code values
......................................................................
Fix code values
This fixes it so it will do v: 1 and v: 2 again but not show v: 0.
Change-Id: I8ad7955045c69c4d5b2ab2770c6b35cd127ebb89
---
M src/preprocess.js
1 file changed, 7 insertions(+), 5 deletions(-)
Approvals:
Paladox: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/preprocess.js b/src/preprocess.js
index d15e662..23e65c9 100644
--- a/src/preprocess.js
+++ b/src/preprocess.js
@@ -106,15 +106,17 @@
if(message.approvals) {
ret.approvals = {};
message.approvals.forEach(function(approval) {
- if(ret.approvals.V > 0) {
- ret.approvals.V = undefined;
- } else if (ret.approvals.C > 0) {
- ret.approvals.C = undefined;
- } else if(approval.type === 'Verified' && approval.value !==
"0") {
+ if(approval.type === 'Verified' && approval.value !== "0") {
ret.approvals.V = approval.value;
} else if (approval.type === 'Code-Review' && approval.value
!== "0") {
ret.approvals.C = approval.value;
}
+ if(approval.type === 'Verified' && approval.value === 0) {
+ ret.approvals.V = undefined;
+ }
+ if(approval.type === 'Code-Review' && approval.value === 0) {
+ ret.approvals.C = undefined;
+ }
});
}
if(ret.user === 'jenkins-bot') {
--
To view, visit https://gerrit.wikimedia.org/r/327120
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ad7955045c69c4d5b2ab2770c6b35cd127ebb89
Gerrit-PatchSet: 2
Gerrit-Project: labs/tools/grrrit
Gerrit-Branch: master
Gerrit-Owner: Paladox <[email protected]>
Gerrit-Reviewer: Paladox <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
