Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/326163 )
Change subject: Gerrit: Fix gitweb (diffusion) file links ...................................................................... Gerrit: Fix gitweb (diffusion) file links When you for example view a diff like https://gerrit.wikimedia.org/r/#/c/326150/2/modules/gerrit/templates/gerrit.config.erb and you click the diffusion link, it takes you to https://phabricator.wikimedia.org/diffusion/OPUP/browse/HEAD/modules/gerrit/templates/gerrit.config.erb/;refs/changes/50/326150/2 but it shows that the file cannot be found, that's because we need to remove / from gerrit.config.erb/;refs/changes/50/326150/2 so it will make it gerrit.config.erb;refs/changes/50/326150/2 https://phabricator.wikimedia.org/diffusion/OPUP/browse/HEAD/modules/gerrit/templates/gerrit.config.erb;refs/changes/50/326150/2 which works Bug: T153130 Change-Id: Iae3d753779d17e6074538b8b78de14e4028a856c --- M modules/gerrit/templates/gerrit.config.erb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dzahn: Verified; Looks good to me, approved diff --git a/modules/gerrit/templates/gerrit.config.erb b/modules/gerrit/templates/gerrit.config.erb index 7685ca3..806a6e3 100644 --- a/modules/gerrit/templates/gerrit.config.erb +++ b/modules/gerrit/templates/gerrit.config.erb @@ -87,7 +87,7 @@ project = /r/project/${project} branch = "/r/branch/${project};${branch}" filehistory = "/r/p/${project}/;history/${file}/;${branch}" - file = "/r/p/${project}/;browse/HEAD/${file}/;${commit}" + file = "/r/p/${project}/;browse/HEAD/${file};${commit}" roottree = "/r/p/${project}/;browse/HEAD/;${commit}" linkname = diffusion linkDrafts = true -- To view, visit https://gerrit.wikimedia.org/r/326163 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae3d753779d17e6074538b8b78de14e4028a856c Gerrit-PatchSet: 5 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Paladox <[email protected]> Gerrit-Reviewer: 20after4 <[email protected]> Gerrit-Reviewer: Chad <[email protected]> Gerrit-Reviewer: Dzahn <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
