WMDE-leszek has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/327163 )
Change subject: Fix assigning void return value to a variable
......................................................................
Fix assigning void return value to a variable
Change-Id: I1e675d121938c5b6b7f8165681c645154e3a70d0
---
M includes/specials/SpecialDeletedContributions.php
M includes/specials/SpecialMIMEsearch.php
M includes/specials/SpecialNewimages.php
M tests/phan/config.php
4 files changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/63/327163/1
diff --git a/includes/specials/SpecialDeletedContributions.php
b/includes/specials/SpecialDeletedContributions.php
index 2936754..5c8b3a6 100644
--- a/includes/specials/SpecialDeletedContributions.php
+++ b/includes/specials/SpecialDeletedContributions.php
@@ -206,7 +206,7 @@
],
];
- $form = HTMLForm::factory( 'ooui', $formDescriptor,
$this->getContext() )
+ HTMLForm::factory( 'ooui', $formDescriptor, $this->getContext()
)
->setWrapperLegendMsg( 'sp-contributions-search' )
->setSubmitTextMsg( 'sp-contributions-submit' )
// prevent setting subpage and 'target' parameter at
the same time
diff --git a/includes/specials/SpecialMIMEsearch.php
b/includes/specials/SpecialMIMEsearch.php
index c61609d..d8a468f 100644
--- a/includes/specials/SpecialMIMEsearch.php
+++ b/includes/specials/SpecialMIMEsearch.php
@@ -119,7 +119,7 @@
],
];
- $form = HTMLForm::factory( 'ooui', $formDescriptor,
$this->getContext() )
+ HTMLForm::factory( 'ooui', $formDescriptor, $this->getContext()
)
->setWrapperLegendMsg( 'mimesearch' )
->setSubmitTextMsg( 'ilsubmit' )
->setAction( $this->getPageTitle()->getLocalURL() )
diff --git a/includes/specials/SpecialNewimages.php
b/includes/specials/SpecialNewimages.php
index 077a5d2..9e3a750 100644
--- a/includes/specials/SpecialNewimages.php
+++ b/includes/specials/SpecialNewimages.php
@@ -108,7 +108,7 @@
unset( $formDescriptor['hidepatrolled'] );
}
- $form = HTMLForm::factory( 'ooui', $formDescriptor,
$this->getContext() )
+ HTMLForm::factory( 'ooui', $formDescriptor, $this->getContext()
)
->setWrapperLegendMsg( 'newimages-legend' )
->setSubmitTextMsg( 'ilsubmit' )
->setMethod( 'get' )
diff --git a/tests/phan/config.php b/tests/phan/config.php
index 7dcc5c4..251336a 100644
--- a/tests/phan/config.php
+++ b/tests/phan/config.php
@@ -341,8 +341,6 @@
"PhanTypeMissingReturn",
// approximate error count: 5
"PhanTypeNonVarPassByRef",
- // approximate error count: 3
- "PhanTypeVoidAssignment",
// approximate error count: 27
"PhanUndeclaredConstant",
// approximate error count: 185
--
To view, visit https://gerrit.wikimedia.org/r/327163
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e675d121938c5b6b7f8165681c645154e3a70d0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
