WMDE-leszek has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/327166 )
Change subject: Reset custom separator transform tables in number formatting
tests
......................................................................
Reset custom separator transform tables in number formatting tests
Looks like custom settings used in a test for number separator
transformation added in Icc9bc09675151645055c7e7f706472a15cc81b0f
influenced RevisonSlider's tests resulting in test failure if
that core test was run before RS test.
Relevant RevisionSlider tests now are ignoring any custom value.
Any value before the test is restored after the test run, though,
in case other tests relied on this (which does not seem to be a case).
Bug: T153121
Change-Id: Ida81b93e4d081b6948e760995a92d182ad79fe0f
---
M tests/qunit/RevisionSlider.RevisionListView.test.js
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider
refs/changes/66/327166/1
diff --git a/tests/qunit/RevisionSlider.RevisionListView.test.js
b/tests/qunit/RevisionSlider.RevisionListView.test.js
index 9e40500..3e327df 100644
--- a/tests/qunit/RevisionSlider.RevisionListView.test.js
+++ b/tests/qunit/RevisionSlider.RevisionListView.test.js
@@ -65,14 +65,18 @@
minor: true
} ),
tooltip,
- tooltipHtml;
+ tooltipHtml,
+ originalSeparatorTransformTable = mw.language.getData(
'en', 'separatorTransformTable' );
revision.setRelativeSize( 2100 );
mw.libs.revisionSlider.userOffset = 0;
+ mw.language.setData( 'en', 'separatorTransformTable', null );
+
tooltip = revisionListView.makeTooltip( revision );
tooltipHtml = tooltip.$element.html();
+ mw.language.setData( 'en', 'separatorTransformTable',
originalSeparatorTransformTable );
assert.ok( tooltipHtml.match( /User1/ ), 'Test the user.' );
assert.ok( tooltipHtml.match( /Hello/ ), 'Test the comment.' );
@@ -80,6 +84,7 @@
assert.ok( tooltipHtml.match( /\+2,100/ ), 'Test the change
size.' );
assert.ok( tooltipHtml.match( /26 April 2016 10:27 AM/ ), 'Test
the date.' );
assert.ok( tooltipHtml.match( /minor/ ), 'Test minor.' );
+
}, mw.config.get( 'wgUserLanguage' ) !== 'en' );
QUnit.test( 'empty user leads to no user line', function ( assert ) {
@@ -168,11 +173,14 @@
QUnit.test( 'big change number is formatted correctly', function (
assert ) {
var revisionListView = new RevisionListView(),
originalUserLangSetting = mw.config.get(
'wgUserLanguage' ),
+ originalSeparatorTransformTable = mw.language.getData(
'en', 'separatorTransformTable' ),
$changeSizeLineHtml;
mw.config.set( 'wgUserLanguage', 'en' );
+ mw.language.setData( 'en', 'separatorTransformTable', null );
$changeSizeLineHtml = revisionListView.makeChangeSizeLine( 1000
);
mw.config.set( 'wgUserLanguage', originalUserLangSetting );
+ mw.language.setData( 'en', 'separatorTransformTable',
originalSeparatorTransformTable );
assert.equal( $changeSizeLineHtml.find(
'.mw-revslider-change-positive' ).text(), '+1,000' );
} );
@@ -180,11 +188,14 @@
QUnit.test( 'page size is formatted correctly', function ( assert ) {
var revisionListView = new RevisionListView(),
originalUserLangSetting = mw.config.get(
'wgUserLanguage' ),
+ originalSeparatorTransformTable = mw.language.getData(
'en', 'separatorTransformTable' ),
$pageSizeLineHtml;
mw.config.set( 'wgUserLanguage', 'en' );
+ mw.language.setData( 'en', 'separatorTransformTable', null );
$pageSizeLineHtml = revisionListView.makePageSizeLine( 1337 );
mw.config.set( 'wgUserLanguage', originalUserLangSetting );
+ mw.language.setData( 'en', 'separatorTransformTable',
originalSeparatorTransformTable );
assert.ok( $pageSizeLineHtml.text().match( /1,337/ ) );
} );
--
To view, visit https://gerrit.wikimedia.org/r/327166
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida81b93e4d081b6948e760995a92d182ad79fe0f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
