jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/326494 )

Change subject: Load bar arrow on left for RTL languages
......................................................................


Load bar arrow on left for RTL languages

Bug: T152913
Change-Id: Ic79be04f8345057ff66ceac6c8fd748682b03a79
---
M RevisionSlider.hooks.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  WMDE-leszek: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/RevisionSlider.hooks.php b/RevisionSlider.hooks.php
index fd1877e..24f42c2 100644
--- a/RevisionSlider.hooks.php
+++ b/RevisionSlider.hooks.php
@@ -78,8 +78,9 @@
                $button = ( new OOUI\Tag( 'a' ) )->setAttributes(
                        [ 'style' => 'width: 100%; padding: 0.06em 0 0.06em 0;' 
]
                );
+               $iconPosition = $out->getLanguage()->isRTL()? 'left' : 'right';
                $label = ( new OOUI\Tag( 'span' ) )->setAttributes( [ 'style' 
=> 'line-height: 1.875em;' ] );
-               $icon = ( new OOUI\Tag( 'span' ) )->setAttributes( [ 'style' => 
'float: right;' ] );
+               $icon = ( new OOUI\Tag( 'span' ) )->setAttributes( [ 'style' => 
"float: $iconPosition;" ] );
 
                $toggleButton = new OOUI\ButtonWidget( [
                        'label' => ( new Message( 'revisionslider-toggle-label' 
) )->text(),

-- 
To view, visit https://gerrit.wikimedia.org/r/326494
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic79be04f8345057ff66ceac6c8fd748682b03a79
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to