Bartosz Dziewoński has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/327179 )
Change subject: mediawiki.page.watch: Avoid lego messages
......................................................................
mediawiki.page.watch: Avoid lego messages
Restructure the code to avoid constructing message names by adding
strings together. Makes it easier to find the usages.
Also, simplify a check for odd/even namespace numbers.
Change-Id: I0b6794cc07ed2a600499632d240b71898715c5b0
---
M resources/src/mediawiki/page/watch.js
1 file changed, 4 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/79/327179/1
diff --git a/resources/src/mediawiki/page/watch.js
b/resources/src/mediawiki/page/watch.js
index 0319c64..f880e6a 100644
--- a/resources/src/mediawiki/page/watch.js
+++ b/resources/src/mediawiki/page/watch.js
@@ -134,14 +134,11 @@
.done( function ( watchResponse ) {
var mwTitle, message, otherAction =
action === 'watch' ? 'unwatch' : 'watch';
- message = action === 'watch' ?
'addedwatchtext' : 'removedwatchtext';
mwTitle = mw.Title.newFromText( title );
- if ( mwTitle &&
mwTitle.getNamespaceId() > 0 &&
- /* eslint-disable no-bitwise */
- ( mwTitle.getNamespaceId() & 1
) === 1
- /* eslint-enable no-bitwise */
- ) {
- message += '-talk';
+ if ( mwTitle &&
mwTitle.getNamespaceId() > 0 && mwTitle.getNamespaceId() % 2 === 1 ) {
+ message = action === 'watch' ?
'addedwatchtext-talk' : 'removedwatchtext-talk';
+ } else {
+ message = action === 'watch' ?
'addedwatchtext' : 'removedwatchtext';
}
mw.notify( mw.message( message, title
).parseDom(), {
--
To view, visit https://gerrit.wikimedia.org/r/327179
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b6794cc07ed2a600499632d240b71898715c5b0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
