Bartosz Dziewoński has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/327182 )
Change subject: NumberInputWidget: Avoid bitwise tricks when checking for
integers
......................................................................
NumberInputWidget: Avoid bitwise tricks when checking for integers
In addition to being more obvious than `n | 0`, `Math.floor( n )` also
works correctly for numbers outside of 32-bit int range.
Change-Id: I772d404fd2f85e0ede017364964773614236380f
---
M src/widgets/NumberInputWidget.js
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/82/327182/1
diff --git a/src/widgets/NumberInputWidget.js b/src/widgets/NumberInputWidget.js
index 2d86957..ac8e6fd 100644
--- a/src/widgets/NumberInputWidget.js
+++ b/src/widgets/NumberInputWidget.js
@@ -265,11 +265,9 @@
return false;
}
- /* eslint-disable no-bitwise */
- if ( this.isInteger && ( n | 0 ) !== n ) {
+ if ( this.isInteger && Math.floor( n ) !== n ) {
return false;
}
- /* eslint-enable no-bitwise */
if ( n < this.min || n > this.max ) {
return false;
--
To view, visit https://gerrit.wikimedia.org/r/327182
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I772d404fd2f85e0ede017364964773614236380f
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
