jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/327170 )
Change subject: Fix header on Special:CX when translating
......................................................................
Fix header on Special:CX when translating
Follow-up to I3dece6996a0bc7657f72e87789d2f74df1382458
Change-Id: Ic33262fdb918e77dfbb6d45ac79fa7e033046b49
(cherry picked from commit b28fc4f0676333c14de6a0cb64e76d4dcb49755e)
---
M extension.json
M modules/stats/ext.cx.stats.js
M modules/ui/mw.cx.ui.Header.js
3 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
KartikMistry: Looks good to me, but someone else must approve
Zfilipin: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index e991c32..52c5df3 100644
--- a/extension.json
+++ b/extension.json
@@ -1218,6 +1218,7 @@
"ui/styles/mw.cx.ui.Header.less"
],
"messages": [
+ "cx",
"login"
],
"dependencies": [
@@ -1265,7 +1266,8 @@
"ui/mw.cx.ui.Columns.js",
"ui/mw.cx.ui.SourceColumn.js",
"ui/mw.cx.ui.TranslationColumn.js",
- "ui/mw.cx.ui.ToolsColumn.js"
],
+ "ui/mw.cx.ui.ToolsColumn.js"
+ ],
"styles": [
"ui/styles/mw.cx.ui.Columns.less"
],
diff --git a/modules/stats/ext.cx.stats.js b/modules/stats/ext.cx.stats.js
index d66ba7b..4477787 100644
--- a/modules/stats/ext.cx.stats.js
+++ b/modules/stats/ext.cx.stats.js
@@ -828,7 +828,8 @@
.append( $header, $container )
);
header = new mw.cx.ui.Header( {
- siteMapper: this.siteMapper
+ siteMapper: this.siteMapper,
+ titleText: mw.msg( 'cx-stats-title' )
} );
$header.append( header.$element );
cxstats = new CXStats( $container, {
diff --git a/modules/ui/mw.cx.ui.Header.js b/modules/ui/mw.cx.ui.Header.js
index d0df1dd..467433d 100644
--- a/modules/ui/mw.cx.ui.Header.js
+++ b/modules/ui/mw.cx.ui.Header.js
@@ -42,7 +42,7 @@
.addClass( 'cx-header__logo' );
$titleText = $( '<span>' )
.addClass( 'cx-header__title-text' )
- .text( this.config.titleText || mw.msg(
'cx-stats-title' ) );
+ .text( this.config.titleText || mw.msg( 'cx' ) );
$headerTitle = $( '<div>' )
.addClass( 'cx-header__title' )
--
To view, visit https://gerrit.wikimedia.org/r/327170
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic33262fdb918e77dfbb6d45ac79fa7e033046b49
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: wmf/1.29.0-wmf.6
Gerrit-Owner: Amire80 <[email protected]>
Gerrit-Reviewer: KartikMistry <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
