Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/327217 )

Change subject: Minor: use msg.meta.topic instead of parsing it out from 
kafkaMessage
......................................................................

Minor: use msg.meta.topic instead of parsing it out from kafkaMessage

Change-Id: I58ceb0de85a1f5fce735104d3c25bbf856dc0f97
---
M lib/edit-stream.js
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/trending-edits 
refs/changes/17/327217/1

diff --git a/lib/edit-stream.js b/lib/edit-stream.js
index 719d9d6..95423e5 100644
--- a/lib/edit-stream.js
+++ b/lib/edit-stream.js
@@ -102,8 +102,7 @@
                     return this.emit('error', e);
                 }
 
-                const pureTopic = 
kafkaMessage.topic.substr(kafkaMessage.topic.indexOf('.') + 1);
-                const skip = COMMIT_PUSH_SKIP[pureTopic];
+                const skip = COMMIT_PUSH_SKIP[msg.meta.topic];
                 if (!skip || kafkaMessage.offset % skip === 0) {
                     this._commitQueue.push({
                         message: kafkaMessage,

-- 
To view, visit https://gerrit.wikimedia.org/r/327217
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I58ceb0de85a1f5fce735104d3c25bbf856dc0f97
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/trending-edits
Gerrit-Branch: master
Gerrit-Owner: Mobrovac <mobro...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to