jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/326075 )
Change subject: Make DifferenceEngine's markPatrolledLink and getRevisionHeader public so that hooked functions can use them where needed ...................................................................... Make DifferenceEngine's markPatrolledLink and getRevisionHeader public so that hooked functions can use them where needed The said hooks were added to core in https://gerrit.wikimedia.org/r/#/c/298026/ . One of the many intended use cases is https://gerrit.wikimedia.org/r/#/c/326074/ which currently fatals due to these two being protected, and obviously we don't want to lose functionality when hooking into one (or more) of the aforementioned hooks. Change-Id: I260c8b57c0bb2af3a6982bd7142b112a4a023391 Depends-On: I02de9069854532faec4c0c1798a10f862e6dfd7c --- M includes/diff/DifferenceEngine.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Reedy: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/diff/DifferenceEngine.php b/includes/diff/DifferenceEngine.php index 5e40f43..c27c89c 100644 --- a/includes/diff/DifferenceEngine.php +++ b/includes/diff/DifferenceEngine.php @@ -482,7 +482,7 @@ * * @return string HTML or empty string */ - protected function markPatrolledLink() { + public function markPatrolledLink() { if ( $this->mMarkPatrolledLink === null ) { $linkInfo = $this->getMarkPatrolledLinkInfo(); // If false, there is no patrol link needed/allowed @@ -1065,7 +1065,7 @@ * * @return string HTML fragment */ - protected function getRevisionHeader( Revision $rev, $complete = '' ) { + public function getRevisionHeader( Revision $rev, $complete = '' ) { $lang = $this->getLanguage(); $user = $this->getUser(); $revtimestamp = $rev->getTimestamp(); -- To view, visit https://gerrit.wikimedia.org/r/326075 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I260c8b57c0bb2af3a6982bd7142b112a4a023391 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Jack Phoenix <[email protected]> Gerrit-Reviewer: Anomie <[email protected]> Gerrit-Reviewer: Reedy <[email protected]> Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
