jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/327386 )

Change subject: Fix wikitext handling of DataTransferHandlers when IVStore is 
used
......................................................................


Fix wikitext handling of DataTransferHandlers when IVStore is used

Bug: T153269
Change-Id: Ida6ffffac6e6a65784dc84a388d3702680a79db9
---
M modules/ve-mw/ui/ve.ui.MWWikitextDataTransferHandlerFactory.js
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/modules/ve-mw/ui/ve.ui.MWWikitextDataTransferHandlerFactory.js 
b/modules/ve-mw/ui/ve.ui.MWWikitextDataTransferHandlerFactory.js
index 417b5d2..03d9140 100644
--- a/modules/ve-mw/ui/ve.ui.MWWikitextDataTransferHandlerFactory.js
+++ b/modules/ve-mw/ui/ve.ui.MWWikitextDataTransferHandlerFactory.js
@@ -50,7 +50,11 @@
                if ( typeof dataOrDoc === 'string' || ( Array.isArray( 
dataOrDoc ) && dataOrDoc.every( isPlain ) ) ) {
                        resolve( dataOrDoc );
                } else {
-                       doc = dataOrDoc instanceof ve.dm.Document ? dataOrDoc : 
new ve.dm.Document( dataOrDoc );
+                       doc = dataOrDoc instanceof ve.dm.Document ?
+                               dataOrDoc :
+                               // The handler may have also written items to 
the store
+                               new ve.dm.Document( new 
ve.dm.ElementLinearData( handler.surface.getModel().getDocument().getStore(), 
dataOrDoc ) );
+
                        ve.init.target.getWikitextFragment( doc, false )
                                .done( resolve )
                                .fail( function () {

-- 
To view, visit https://gerrit.wikimedia.org/r/327386
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ida6ffffac6e6a65784dc84a388d3702680a79db9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to