jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/327414 )

Change subject: Properly clear this.section when switching from VE
......................................................................


Properly clear this.section when switching from VE

Bug: T153276
Change-Id: Idc251c73c03bf87b6e6ca716be98b38d4fb68c5e
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js 
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
index 290fe93..85d5037 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
@@ -1631,12 +1631,15 @@
        var uri, oldid, prefPromise, dataPromise,
                target = this;
 
+       // We may have this.section but VE is always full page at the moment
+       this.section = null;
+
        if ( ve.init.target.isModeAvailable( 'source' ) && !leaveVE ) {
                if ( discardChanges ) {
                        dataPromise = mw.libs.ve.targetLoader.requestPageData(
                                'source',
                                this.pageName,
-                               null, // We may have this.section but VE is 
always full page at the moment
+                               this.section,
                                this.requestedRevId,
                                this.constructor.name
                        ).then(

-- 
To view, visit https://gerrit.wikimedia.org/r/327414
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idc251c73c03bf87b6e6ca716be98b38d4fb68c5e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Catrope <r...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to