Alexandros Kosiaris has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/326452 )

Change subject: k8s::apiserver: Remove unused master_host parameter
......................................................................


k8s::apiserver: Remove unused master_host parameter

The master_host parameter on k8s::apiserver class is not used by
anything in the module, so removing

Change-Id: Ia1042f2861100686fcb8f3d1b9e8c3eb97b8ad1f
---
M modules/k8s/manifests/apiserver.pp
M modules/role/manifests/toollabs/k8s/master.pp
2 files changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Alexandros Kosiaris: Verified; Looks good to me, approved



diff --git a/modules/k8s/manifests/apiserver.pp 
b/modules/k8s/manifests/apiserver.pp
index 60c386e..4955cf9 100644
--- a/modules/k8s/manifests/apiserver.pp
+++ b/modules/k8s/manifests/apiserver.pp
@@ -1,6 +1,5 @@
 class k8s::apiserver(
     $etcd_servers,
-    $master_host,
     $docker_registry,
     $ssl_certificate_name,
     $host_automounts = [],
diff --git a/modules/role/manifests/toollabs/k8s/master.pp 
b/modules/role/manifests/toollabs/k8s/master.pp
index b8965ca..7d0d28e 100644
--- a/modules/role/manifests/toollabs/k8s/master.pp
+++ b/modules/role/manifests/toollabs/k8s/master.pp
@@ -11,7 +11,6 @@
     }
 
     class { '::k8s::apiserver':
-        master_host                => $master_host,
         etcd_servers               => $etcd_url,
         docker_registry            => hiera('docker::registry'),
         host_automounts            => ['/var/run/nslcd/socket'],

-- 
To view, visit https://gerrit.wikimedia.org/r/326452
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1042f2861100686fcb8f3d1b9e8c3eb97b8ad1f
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: Gehel <[email protected]>
Gerrit-Reviewer: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: Yuvipanda <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to