Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/327567 )
Change subject: Hygiene: don't constrain article header title height
......................................................................
Hygiene: don't constrain article header title height
This code didn't seem to have any effect
Bug: T152213
Change-Id: Ifcf14dd02c2b883e673acca4f4e75abae8ea9157
---
M app/src/main/java/org/wikipedia/page/leadimages/ArticleHeaderView.java
1 file changed, 2 insertions(+), 19 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/67/327567/1
diff --git
a/app/src/main/java/org/wikipedia/page/leadimages/ArticleHeaderView.java
b/app/src/main/java/org/wikipedia/page/leadimages/ArticleHeaderView.java
index 900d305..6391f2a 100644
--- a/app/src/main/java/org/wikipedia/page/leadimages/ArticleHeaderView.java
+++ b/app/src/main/java/org/wikipedia/page/leadimages/ArticleHeaderView.java
@@ -29,7 +29,6 @@
import android.view.Gravity;
import android.view.MenuItem;
import android.view.View;
-import android.view.ViewGroup;
import android.widget.FrameLayout;
import android.widget.ImageView;
import android.widget.LinearLayout;
@@ -117,7 +116,6 @@
setTextColor(getColor(getThemedAttributeId(getContext(),
R.attr.lead_text_color)));
- setTextHeightUnconstrained();
}
public void showTextImage() {
@@ -314,25 +312,10 @@
TextUtils.isEmpty(subtitle) ? new StyleSpan(Typeface.ITALIC) :
null);
}
- @SuppressWarnings("checkstyle:magicnumber")
private void setImageHeight(int height) {
+ final float oneThird = 1 / 3;
DimenUtil.setViewHeight(image, height);
- DimenUtil.setViewHeight(gradient, height / 3);
- }
-
- private void setTextHeightConstrained() {
- LinearLayout.LayoutParams params = (LinearLayout.LayoutParams)
titleText.getLayoutParams();
- params.width = ViewGroup.LayoutParams.MATCH_PARENT;
- params.height = 0;
- params.weight = 1f;
- titleText.setLayoutParams(params);
- }
-
- private void setTextHeightUnconstrained() {
- LinearLayout.LayoutParams params = (LinearLayout.LayoutParams)
titleText.getLayoutParams();
- params.width = ViewGroup.LayoutParams.MATCH_PARENT;
- params.height = ViewGroup.LayoutParams.WRAP_CONTENT;
- titleText.setLayoutParams(params);
+ DimenUtil.setViewHeight(gradient, (int) oneThird * height);
}
private void init() {
--
To view, visit https://gerrit.wikimedia.org/r/327567
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifcf14dd02c2b883e673acca4f4e75abae8ea9157
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
