Dzahn has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/320547 )
Change subject: role::jsbench: Restrict to production networks
......................................................................
role::jsbench: Restrict to production networks
We're getting rid of $INTERNAL, since it's needlessly broad. xvfb is only
accessed from production hosts for debugging, so restrict it to production
networks.
Change-Id: I0a209f803b21d666c8f378c38aa9501a48952230
---
M modules/role/manifests/jsbench.pp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Dzahn: Looks good to me, approved
diff --git a/modules/role/manifests/jsbench.pp
b/modules/role/manifests/jsbench.pp
index b419031..e68021e 100644
--- a/modules/role/manifests/jsbench.pp
+++ b/modules/role/manifests/jsbench.pp
@@ -30,7 +30,7 @@
ferm::service { 've-xvfb':
proto => 'tcp',
port => '6099',
- srange => '$INTERNAL',
+ srange => '$PRODUCTION_NETWORKS',
}
user { 'jsbench':
--
To view, visit https://gerrit.wikimedia.org/r/320547
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a209f803b21d666c8f378c38aa9501a48952230
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
