Dzahn has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/321371 )
Change subject: Tools proxy: Restrict to labs networks
......................................................................
Tools proxy: Restrict to labs networks
$INTERNAL is needlessly broad and also covers 10.x networks from production.
Restrict access to labs networks.
Change-Id: I41091222e6e86296f60f1236efe95cd249a1d1a3
---
M modules/role/manifests/toollabs/proxy.pp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Dzahn: Looks good to me, approved
diff --git a/modules/role/manifests/toollabs/proxy.pp
b/modules/role/manifests/toollabs/proxy.pp
index b83d87c..876a0b3 100644
--- a/modules/role/manifests/toollabs/proxy.pp
+++ b/modules/role/manifests/toollabs/proxy.pp
@@ -7,7 +7,7 @@
proto => 'tcp',
port => '8081',
desc => 'Proxymanager service for Labs instances',
- srange => '$INTERNAL',
+ srange => '$LABS_NETWORKS',
}
ferm::service{ 'http':
--
To view, visit https://gerrit.wikimedia.org/r/321371
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41091222e6e86296f60f1236efe95cd249a1d1a3
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: Rush <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
