Aaron Schulz has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/327698 )
Change subject: Fix various minor IDEA warnings in LoadBalancer
......................................................................
Fix various minor IDEA warnings in LoadBalancer
Change-Id: Ic65a04ca1b988fe36e088709d7dc4e981670cb62
---
M includes/libs/rdbms/loadbalancer/LoadBalancer.php
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/98/327698/1
diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancer.php
b/includes/libs/rdbms/loadbalancer/LoadBalancer.php
index 8601785..baab031 100644
--- a/includes/libs/rdbms/loadbalancer/LoadBalancer.php
+++ b/includes/libs/rdbms/loadbalancer/LoadBalancer.php
@@ -441,12 +441,15 @@
/**
* @param int $i
- * @return IDatabase
+ * @return IDatabase|bool
*/
public function getAnyOpenConnection( $i ) {
foreach ( $this->mConns as $connsByServer ) {
if ( !empty( $connsByServer[$i] ) ) {
- return reset( $connsByServer[$i] );
+ /** @var $serverConns IDatabase[] */
+ $serverConns = $connsByServer[$i];
+
+ return reset( $serverConns );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/327698
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic65a04ca1b988fe36e088709d7dc4e981670cb62
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
