jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/327502 )
Change subject: IcuCollation: Add the current class name to 'first-letters' cache key ...................................................................... IcuCollation: Add the current class name to 'first-letters' cache key Instances of subclasses of IcuCollation with customizations for specific languages probably shouldn't share this cache with instances of IcuCollation with the same language. Change-Id: I06d66d199c99448a3375381baef0366c4d99c8c4 --- M includes/collation/IcuCollation.php 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ladsgroup: Looks good to me, but someone else must approve Legoktm: Looks good to me, approved jenkins-bot: Verified Thiemo Mättig (WMDE): Looks good to me, but someone else must approve diff --git a/includes/collation/IcuCollation.php b/includes/collation/IcuCollation.php index 7b4fce6..bc5a209 100644 --- a/includes/collation/IcuCollation.php +++ b/includes/collation/IcuCollation.php @@ -330,6 +330,7 @@ $cache = ObjectCache::getLocalServerInstance( CACHE_ANYTHING ); $cacheKey = $cache->makeKey( 'first-letters', + get_class( $this ), $this->locale, $this->digitTransformLanguage->getCode(), self::getICUVersion(), -- To view, visit https://gerrit.wikimedia.org/r/327502 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06d66d199c99448a3375381baef0366c4d99c8c4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com> Gerrit-Reviewer: Legoktm <lego...@member.fsf.org> Gerrit-Reviewer: Reedy <re...@wikimedia.org> Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits