Matěj Suchánek has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/327790 )
Change subject: Don't show link to testing interface when the user cannot test
filters
......................................................................
Don't show link to testing interface when the user cannot test filters
Clicking on this link only shows an error message unless the user can
edit filters.
Change-Id: Id912731e98f0f37b999d4a8e7ab190cd938825aa
---
M Views/AbuseFilterViewEdit.php
1 file changed, 20 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AbuseFilter
refs/changes/90/327790/2
diff --git a/Views/AbuseFilterViewEdit.php b/Views/AbuseFilterViewEdit.php
index 9d02855..b47ad13 100644
--- a/Views/AbuseFilterViewEdit.php
+++ b/Views/AbuseFilterViewEdit.php
@@ -472,25 +472,27 @@
$fields['abusefilter-edit-flags'] = $flags;
$tools = '';
- if ( $filter != 'new' && $user->isAllowed( 'abusefilter-revert'
) ) {
- $tools .= Xml::tags(
- 'p', null,
- $this->linkRenderer->makeLink(
- $this->getTitle( 'revert/' . $filter ),
- $this->msg( 'abusefilter-edit-revert'
)->text()
- )
- );
- }
-
if ( $filter != 'new' ) {
- // Test link
- $tools .= Xml::tags(
- 'p', null,
- $this->linkRenderer->makeLink(
- $this->getTitle( "test/$filter" ),
- new HtmlArmor( $this->msg(
'abusefilter-edit-test-link' )->parse() )
- )
- );
+ if ( $user->isAllowed( 'abusefilter-revert' ) ) {
+ $tools .= Xml::tags(
+ 'p', null,
+ $this->linkRenderer->makeLink(
+ $this->getTitle(
"revert/$filter" ),
+ $this->msg(
'abusefilter-edit-revert' )->text()
+ )
+ );
+ }
+
+ if ( $user->isAllowed( 'abusefilter-modify' ) ) {
+ // Test link
+ $tools .= Xml::tags(
+ 'p', null,
+ $this->linkRenderer->makeLink(
+ $this->getTitle( "test/$filter"
),
+ new HtmlArmor( $this->msg(
'abusefilter-edit-test-link' )->parse() )
+ )
+ );
+ }
// Last modification details
$userLink =
Linker::userLink( $row->af_user,
$row->af_user_text ) .
--
To view, visit https://gerrit.wikimedia.org/r/327790
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id912731e98f0f37b999d4a8e7ab190cd938825aa
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
