Jack Phoenix has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/327931 )

Change subject: Version 0.9.1: use the core-provided error message and error 
message CSS class instead of rolling out our own solution
......................................................................

Version 0.9.1: use the core-provided error message and error message CSS class 
instead of rolling out our own solution

Bug: T147255
Bug: T153526
Change-Id: If6c27268c9db0e3ba87d3fdb1f0511245ceb424d
---
M NewSignupPage.js
M extension.json
M i18n/en.json
M i18n/fi.json
4 files changed, 4 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/NewSignupPage 
refs/changes/31/327931/1

diff --git a/NewSignupPage.js b/NewSignupPage.js
index 810a080..70a5070 100644
--- a/NewSignupPage.js
+++ b/NewSignupPage.js
@@ -21,9 +21,9 @@
                        !( $( 'input#wpPassword2' ).val() === $( 
'input#wpRetype' ).val() )
                )
                {
-                       var message = mw.msg( 'newsignuppage-password-mismatch' 
);
+                       var message = mw.msg( 'badretype' );
                        $( 'input#wpRetype' ).parent().append(
-                               '<span id="password-match-check-result" 
style="padding: 2px; color: red">' +
+                               '<span id="password-match-check-result" 
class="error">' +
                                message + '</span>'
                        );
                }
diff --git a/extension.json b/extension.json
index d3222d5..829828e 100644
--- a/extension.json
+++ b/extension.json
@@ -1,6 +1,6 @@
 {
        "name": "New Signup Page",
-       "version": "0.9",
+       "version": "0.9.1",
        "author": [
                "Jack Phoenix"
        ],
@@ -37,7 +37,7 @@
                "ext.newsignuppage": {
                        "scripts": "NewSignupPage.js",
                        "messages": [
-                               "newsignuppage-password-mismatch"
+                               "badretype"
                        ],
                        "position": "bottom"
                }
diff --git a/i18n/en.json b/i18n/en.json
index 4f9b117..6201302 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -2,7 +2,6 @@
        "@metadata": {
                "authors": []
        },
-       "newsignuppage-password-mismatch": "Passwords don't match!",
        "newsignuppage-recruited": "recruited [$1 $2]",
        "shoutwiki-loginform-tos": "I am over 13 years of age and I have read, 
understood and agree to be bound by the 
[http://www.shoutwiki.com/wiki/Terms_of_use Terms of Service] and 
[http://www.shoutwiki.com/wiki/Privacy_policy Privacy Policy]",
        "shoutwiki-must-accept-tos": "You must accept the site's Terms of 
Service in order to be able to create an account!",
diff --git a/i18n/fi.json b/i18n/fi.json
index 853fd7a..1fd951e 100644
--- a/i18n/fi.json
+++ b/i18n/fi.json
@@ -2,7 +2,6 @@
     "@metadata": {
         "authors": []
     },
-       "newsignuppage-password-mismatch": "Salasanat eivät täsmää!",
     "newsignuppage-recruited": "värväsi käyttäjän [$1 $2]",
     "shoutwiki-loginform-tos": "Olen yli 13-vuotias ja olen lukenut, 
ymmärtänyt ja sitoutunut noudattamaan 
[http://www.shoutwiki.com/wiki/Terms_of_use käyttöehtoja] ja 
[http://www.shoutwiki.com/wiki/Privacy_policy tietosuojakäytäntöä]",
     "shoutwiki-must-accept-tos": "Sinun tulee hyväksyä sivuston käyttöehdot 
voidaksesi luoda tunnuksen!",

-- 
To view, visit https://gerrit.wikimedia.org/r/327931
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If6c27268c9db0e3ba87d3fdb1f0511245ceb424d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NewSignupPage
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to