Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/328039 )

Change subject: Don't allow $section to be unset
......................................................................

Don't allow $section to be unset

Change-Id: I46a36a08fc2e98aeb35774af8b26ebee313965f3
---
M ApiVisualEditor.php
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/39/328039/1

diff --git a/ApiVisualEditor.php b/ApiVisualEditor.php
index dd8eef2..53ad089 100644
--- a/ApiVisualEditor.php
+++ b/ApiVisualEditor.php
@@ -239,9 +239,7 @@
                                                        'rvprop' => 
'content|ids'
                                                ];
 
-                                               if ( isset( $params['section'] 
) ) {
-                                                       $section = 
$params['section'];
-                                               }
+                                               $section = isset( 
$params['section'] ) ? $params['section'] : null;
 
                                                if ( $section === 'new' ) {
                                                        $content = '';

-- 
To view, visit https://gerrit.wikimedia.org/r/328039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I46a36a08fc2e98aeb35774af8b26ebee313965f3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to