Paladox has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/328045 )
Change subject: build: Replace jshint and jscs with eslint ...................................................................... build: Replace jshint and jscs with eslint Change-Id: I8fb7efe8733718d871c6d3a85c7afacc84f84d97 --- A .eslintrc.json D .jscsrc D .jshintignore D .jshintrc M Gruntfile.js M package.json 6 files changed, 4 insertions(+), 38 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Metrolook refs/changes/45/328045/1 diff --git a/.eslintrc.json b/.eslintrc.json new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/.eslintrc.json diff --git a/.jscsrc b/.jscsrc deleted file mode 100644 index 9d22e3f..0000000 --- a/.jscsrc +++ /dev/null @@ -1,3 +0,0 @@ -{ - "preset": "wikimedia" -} diff --git a/.jshintignore b/.jshintignore deleted file mode 100644 index 099f69c..0000000 --- a/.jshintignore +++ /dev/null @@ -1,4 +0,0 @@ -node_modules -vendor - -js/overthrow.js diff --git a/.jshintrc b/.jshintrc deleted file mode 100644 index 66e3d48..0000000 --- a/.jshintrc +++ /dev/null @@ -1,24 +0,0 @@ -{ - // Enforcing - "bitwise": true, - "eqeqeq": true, - "freeze": true, - "latedef": true, - "noarg": true, - "nonew": true, - "undef": true, - "unused": true, - "strict": false, - - // Relaxing - "es5": false, - - // Environment - "browser": true, - "jquery": true, - - "globals": { - "mediaWiki": false, - "OO": false - } -} diff --git a/Gruntfile.js b/Gruntfile.js index 006f96e..a6783da 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -7,10 +7,7 @@ grunt.loadNpmTasks( 'grunt-jscs' ); grunt.initConfig( { - jshint: { - options: { - jshintrc: true - }, + eslint: { all: [ '*.js', '**/*.js', @@ -34,6 +31,6 @@ } } ); - grunt.registerTask( 'test', [ 'jshint', 'jscs', 'jsonlint', 'banana' ] ); + grunt.registerTask( 'test', [ 'eslint', 'jsonlint', 'banana' ] ); grunt.registerTask( 'default', 'test' ); }; diff --git a/package.json b/package.json index 22a0263..2836b23 100644 --- a/package.json +++ b/package.json @@ -6,9 +6,9 @@ }, "devDependencies": { "grunt": "1.0.1", - "grunt-contrib-jshint": "1.0.0", + "grunt-eslint": "19.0.0", + "eslint-config-wikimedia": "0.3.0", "grunt-banana-checker": "0.5.0", - "grunt-jscs": "2.8.0", "grunt-jsonlint": "1.1.0" } } -- To view, visit https://gerrit.wikimedia.org/r/328045 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8fb7efe8733718d871c6d3a85c7afacc84f84d97 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/skins/Metrolook Gerrit-Branch: master Gerrit-Owner: Paladox <thomasmulhall...@yahoo.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits