jenkins-bot has submitted this change and it was merged.

Change subject: [JobQueue] Avoid spamming the runJobs log with large blobs.
......................................................................


[JobQueue] Avoid spamming the runJobs log with large blobs.

Change-Id: I5a69350c0486edd9368ebbd2e42ab51f03b682d8
---
M includes/job/Job.php
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Anomie: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/job/Job.php b/includes/job/Job.php
index 9bd2031..e23d1c3 100644
--- a/includes/job/Job.php
+++ b/includes/job/Job.php
@@ -245,12 +245,15 @@
                                if ( $paramString != '' ) {
                                        $paramString .= ' ';
                                }
-
                                if ( is_array( $value ) ) {
                                        $value = "array(" . count( $value ) . 
")";
-                               } else if ( is_object( $value ) && 
!method_exists( $value, '__toString' ) ) {
+                               } elseif ( is_object( $value ) && 
!method_exists( $value, '__toString' ) ) {
                                        $value = "object(" . get_class( $value 
) . ")";
                                }
+                               $value = (string)$value;
+                               if ( mb_strlen( $value ) > 1024 ) {
+                                       $value = "string(" . mb_strlen( $value 
) . ")";
+                               }
 
                                $paramString .= "$key=$value";
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/49201
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5a69350c0486edd9368ebbd2e42ab51f03b682d8
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: IAlex <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to