jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/328496 )
Change subject: Use default wiki id in example settings. ...................................................................... Use default wiki id in example settings. Until now, we force the local wiki ID to "mywiki" in the exampel settings. This triggers a warning if "mywiki" is not known to the SiteLookup. Instead of forcing a fixed value, we can just rely on the default for the local site ID, which is the wiki's database name. That is consistent with the conventions used on the WMF cluster. Bug: T153729 Change-Id: Ia0d578a8215280592001cfa5f413fb76e15a2d2f --- M client/config/WikibaseClient.example.php 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: jenkins-bot: Verified Thiemo Mättig (WMDE): Looks good to me, approved diff --git a/client/config/WikibaseClient.example.php b/client/config/WikibaseClient.example.php index 1a32481..4ce9e51 100644 --- a/client/config/WikibaseClient.example.php +++ b/client/config/WikibaseClient.example.php @@ -19,7 +19,8 @@ } // The global site ID by which this wiki is known on the repo. -$wgWBClientSettings['siteGlobalID'] = "mywiki"; +// Defaults to $wgDBname. +// $wgWBClientSettings['siteGlobalID'] = "mywiki"; $wgWBClientSettings['injectRecentChanges'] = true; $wgWBClientSettings['showExternalRecentChanges'] = true; -- To view, visit https://gerrit.wikimedia.org/r/328496 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0d578a8215280592001cfa5f413fb76e15a2d2f Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Addshore <[email protected]> Gerrit-Reviewer: Aude <[email protected]> Gerrit-Reviewer: Gergő Tisza <[email protected]> Gerrit-Reviewer: Hoo man <[email protected]> Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
