jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/322421 )

Change subject: Remove bad default from Property.__init__
......................................................................


Remove bad default from Property.__init__

Argument id should always be given because calling None.upper() will
throw an error.

Change-Id: Ia3281a956b33cdb77bd8cfa245c51804430c62a3
---
M pywikibot/page.py
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Dalba: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/pywikibot/page.py b/pywikibot/page.py
index 2549ff2..586e907 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -4247,12 +4247,14 @@
                    'external-id': 'string',
                    }
 
-    def __init__(self, site, id=None, datatype=None):
+    def __init__(self, site, id, datatype=None):
         """
         Constructor.
 
         @param site: data repository
         @type site: pywikibot.site.DataSite
+        @param id: id of the property
+        @type id: basestring
         @param datatype: datatype of the property;
             if not given, it will be queried via the API
         @type datatype: basestring

-- 
To view, visit https://gerrit.wikimedia.org/r/322421
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3281a956b33cdb77bd8cfa245c51804430c62a3
Gerrit-PatchSet: 5
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek <[email protected]>
Gerrit-Reviewer: Dalba <[email protected]>
Gerrit-Reviewer: Matěj Suchánek <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to