Nischayn22 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/49478
Change subject: (bug 38345) use :hover instead of jQuery based styling.
......................................................................
(bug 38345) use :hover instead of jQuery based styling.
Change-Id: Idd8ca7856b07775c0686c94388b78fbd63b193d9
---
M modules/ext.moodBar/ext.moodBar.core.css
M modules/ext.moodBar/ext.moodBar.core.js
2 files changed, 6 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MoodBar
refs/changes/78/49478/1
diff --git a/modules/ext.moodBar/ext.moodBar.core.css
b/modules/ext.moodBar/ext.moodBar.core.css
index 979fd06..6dd0c60 100644
--- a/modules/ext.moodBar/ext.moodBar.core.css
+++ b/modules/ext.moodBar/ext.moodBar.core.css
@@ -191,11 +191,11 @@
/* @embed */
background-image: url(images/type-happy-normal.png);
}
-.mw-moodBar-types-hover .mw-moodBar-type-happy {
+.mw-moodBar-types:hover .mw-moodBar-type-happy {
/* @embed */
background-image: url(images/type-happy-hoverside.png);
}
-.mw-moodBar-types-hover .mw-moodBar-type-happy:hover {
+.mw-moodBar-types .mw-moodBar-type-happy:hover {
/* @embed */
background-image: url(images/type-happy-hovered.png);
}
@@ -213,11 +213,11 @@
/* @embed */
background-image: url(images/type-sad-normal.png);
}
-.mw-moodBar-types-hover .mw-moodBar-type-sad {
+.mw-moodBar-types:hover .mw-moodBar-type-sad {
/* @embed */
background-image: url(images/type-sad-hoverside.png);
}
-.mw-moodBar-types-hover .mw-moodBar-type-sad:hover {
+.mw-moodBar-types .mw-moodBar-type-sad:hover {
/* @embed */
background-image: url(images/type-sad-hovered.png);
}
@@ -235,11 +235,11 @@
/* @embed */
background-image: url(images/type-confused-normal.png);
}
-.mw-moodBar-types-hover .mw-moodBar-type-confused {
+.mw-moodBar-types:hover .mw-moodBar-type-confused {
/* @embed */
background-image: url(images/type-confused-hoverside.png);
}
-.mw-moodBar-types-hover .mw-moodBar-type-confused:hover {
+.mw-moodBar-types .mw-moodBar-type-confused:hover {
/* @embed */
background-image: url(images/type-confused-hovered.png);
}
diff --git a/modules/ext.moodBar/ext.moodBar.core.js
b/modules/ext.moodBar/ext.moodBar.core.js
index 8d2f20b..eb2d1ab 100644
--- a/modules/ext.moodBar/ext.moodBar.core.js
+++ b/modules/ext.moodBar/ext.moodBar.core.js
@@ -236,11 +236,6 @@
} );
return elems;
} )
- .hover( function() {
- $( this ).addClass(
'mw-moodBar-types-hover' );
- }, function() {
- $( this ).removeClass(
'mw-moodBar-types-hover' );
- } )
.end()
// Link what-button
.find( '.mw-moodBar-overlayWhatTrigger' )
--
To view, visit https://gerrit.wikimedia.org/r/49478
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd8ca7856b07775c0686c94388b78fbd63b193d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MoodBar
Gerrit-Branch: master
Gerrit-Owner: Nischayn22 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
