Hello TheDJ,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/329130
to review the following change.
Change subject: Do not ignore all .mli files in texvccheck
......................................................................
Do not ignore all .mli files in texvccheck
The pattern "*.mli" was incorrectly added to texvccheck/.gitignore by
4c9dc2f08e03ad23e1e2f0cefc52ca6893fbe6a2 with the comment "Compiled
source". As with d9a7da14f10f6c53bdf1a18febab030d48f0a960, .mli files
define the interfaces for the corresponding .ml module and thus should
not be ignored.
The only exception to this is parser.mli which is generated by the
ocamlyacc from the parser.mly definition, so this change only ignores
those files.
Change-Id: I263df70e58fb14a7228c32d5c985ff7f1b841891
---
M math/.gitignore
M texvccheck/.gitignore
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Math
refs/changes/30/329130/1
diff --git a/math/.gitignore b/math/.gitignore
index 18dc1ad..9216c19 100644
--- a/math/.gitignore
+++ b/math/.gitignore
@@ -2,6 +2,7 @@
*.cmi
*.cmx
*.o
+parser.mli
# The binaries
texvc
diff --git a/texvccheck/.gitignore b/texvccheck/.gitignore
index be7dcb9..3c1635a 100644
--- a/texvccheck/.gitignore
+++ b/texvccheck/.gitignore
@@ -1,9 +1,8 @@
# Compiled source
-*.mli
-!tex.mli
*.cmi
*.cmx
*.o
+parser.mli
# The binaries
texvccheck
--
To view, visit https://gerrit.wikimedia.org/r/329130
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I263df70e58fb14a7228c32d5c985ff7f1b841891
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Math
Gerrit-Branch: master
Gerrit-Owner: Tim Landscheidt <t...@tim-landscheidt.de>
Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
