UltrasonicNXT has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/329537 )

Change subject: Change the loading dots to a GIF
......................................................................

Change the loading dots to a GIF

Bug:T147270
Change-Id: I5b9c7f071978a96b18dae8e4a7ef17cf2c2350fc
---
M MediaWikiChat.js
M SpecialChat.php
M SpecialChat.template.php
M extension.json
4 files changed, 5 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MediaWikiChat 
refs/changes/37/329537/1

diff --git a/MediaWikiChat.js b/MediaWikiChat.js
index 19c876c..d53930b 100644
--- a/MediaWikiChat.js
+++ b/MediaWikiChat.js
@@ -705,23 +705,10 @@
                }
                window.clearInterval( MediaWikiChat.pollInterval );
                MediaWikiChat.pollInterval = setInterval( MediaWikiChat.getNew, 
interval );
-       },
-
-       loadingBackground: function() {
-               $( '#mwchat-loading-3' ).animate( { opacity: 1 } );
-               $( '#mwchat-loading-2' ).animate( { opacity: 0 }, function() {
-                       $( '#mwchat-loading-3' ).animate( { opacity: 0 } );
-                       $( '#mwchat-loading-1' ).animate( { opacity: 1 }, 
function() {
-                               $( '#mwchat-loading-2' ).animate( { opacity: 1 
} );
-                               $( '#mwchat-loading-1' ).animate( { opacity: 0 
}, MediaWikiChat.loadingBackground );
-                       });
-               });
        }
 };
 
 $( document ).ready( function() {
-       MediaWikiChat.loadingBackground();
-
        $( $( '#mwchat-type input' )[0] ).keydown( function( e ) { // Send text
                MediaWikiChat.clearMentions();
 
diff --git a/SpecialChat.php b/SpecialChat.php
index 2df2aeb..9876e4c 100644
--- a/SpecialChat.php
+++ b/SpecialChat.php
@@ -38,8 +38,9 @@
 
                        // Load modules via ResourceLoader
                        $modules = array(
-                                       'ext.mediawikichat.css',
-                                       'ext.mediawikichat.js',
+                               'ext.mediawikichat.css',
+                               'ext.mediawikichat.js',
+                               'mediawiki.feedback' // for the loading gif
                        );
                        $out->addModules( $modules );
 
diff --git a/SpecialChat.template.php b/SpecialChat.template.php
index 09fd7b2..1955e24 100644
--- a/SpecialChat.template.php
+++ b/SpecialChat.template.php
@@ -29,9 +29,7 @@
                                        </table>
                                </div>
                                <div id="mwchat-type">
-                                       <span id="mwchat-loading" 
style="opacity:0;" data-queue="0">
-                                               <span 
id="mwchat-loading-1">&bull;</span><span 
id="mwchat-loading-2">&bull;</span><span id="mwchat-loading-3">&bull;</span>
-                                       </span>
+                                       <span id="mwchat-loading" 
style="opacity:0;" data-queue="0" class="feedback-spinner"></span><?php // 
.feedback-spinner adds the loading gif ?>
                                        <input type="text" placeholder="<?php 
echo wfMessage( 'chat-type-your-message' )->plain() ?>" />
                                </div>
                        </div>
diff --git a/extension.json b/extension.json
index 74a70ce..41bb56c 100644
--- a/extension.json
+++ b/extension.json
@@ -1,6 +1,6 @@
 {
        "name": "MediaWikiChat",
-       "version": "2.17.4",
+       "version": "2.17.5",
        "author": [
                "Adam Carter/UltrasonicNXT"
        ],

-- 
To view, visit https://gerrit.wikimedia.org/r/329537
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b9c7f071978a96b18dae8e4a7ef17cf2c2350fc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MediaWikiChat
Gerrit-Branch: master
Gerrit-Owner: UltrasonicNXT <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to