MarkAHershberger has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/329539 )
Change subject: Superfluous \n in PageForms changes how checkboxes render in a
table
......................................................................
Superfluous \n in PageForms changes how checkboxes render in a table
Full explanation on bug.
Bug: T154259
Change-Id: I286a40ef3f33c15552f6ea5bb9abb4e963935acb
---
M includes/forminputs/PF_CheckboxesInput.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageForms
refs/changes/39/329539/1
diff --git a/includes/forminputs/PF_CheckboxesInput.php
b/includes/forminputs/PF_CheckboxesInput.php
index 69f89ba..308b8e8 100644
--- a/includes/forminputs/PF_CheckboxesInput.php
+++ b/includes/forminputs/PF_CheckboxesInput.php
@@ -89,7 +89,7 @@
$text .= "\t" . Html::rawElement( 'label',
array( 'class' => $labelClass ),
$checkbox_input . ' ' . $label
- ) . "\n";
+ ) . " ";
$wgPageFormsTabIndex++;
$wgPageFormsFieldNum++;
}
--
To view, visit https://gerrit.wikimedia.org/r/329539
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I286a40ef3f33c15552f6ea5bb9abb4e963935acb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageForms
Gerrit-Branch: master
Gerrit-Owner: MarkAHershberger <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits