WikidataBuilder has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/329594 )
Change subject: New Wikidata Build - 2016-12-29T10:00:01+0000
......................................................................
New Wikidata Build - 2016-12-29T10:00:01+0000
Change-Id: I1c62e28dd551d2d4a98332eaae1f3af1480010e1
---
M composer.lock
M extensions/Wikibase/client/i18n/atj.json
M extensions/Wikibase/client/i18n/es.json
M extensions/Wikibase/client/i18n/sty.json
M extensions/Wikibase/client/includes/DispatchingServiceFactory.php
M extensions/Wikibase/client/includes/Hooks/InterwikiSortingHookHandlers.php
M
extensions/Wikibase/client/includes/Notifications/PageConnectionPresentationModel.php
M
extensions/Wikibase/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseEntityLibraryTest.php
M
extensions/Wikibase/client/tests/phpunit/includes/DispatchingServiceWiringTest.php
M
extensions/Wikibase/client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php
M
extensions/Wikibase/client/tests/phpunit/includes/Store/RepositoryServiceWiringTest.php
M extensions/Wikibase/lib/includes/Store/PropertyInfoLookup.php
M extensions/Wikibase/lib/includes/Store/Sql/SqlEntityInfoBuilder.php
M extensions/Wikibase/lib/tests/phpunit/EntityTypesTest.php
M
extensions/Wikibase/lib/tests/phpunit/Formatters/CommonsThumbnailFormatterTest.php
M extensions/Wikibase/lib/tests/phpunit/Store/DispatchingTermBufferTest.php
M
extensions/Wikibase/lib/tests/phpunit/Store/HttpUrlPropertyOrderProviderTest.php
M extensions/Wikibase/lib/tests/phpunit/Store/MockPropertyInfoStoreTest.php
M
extensions/Wikibase/lib/tests/phpunit/Store/WikiPagePropertyOrderProviderTest.php
M extensions/Wikibase/lib/tests/phpunit/Units/UnitStorageTest.php
M extensions/Wikibase/repo/i18n/lb.json
M extensions/Wikibase/repo/i18n/zh-hans.json
M extensions/Wikibase/repo/includes/Api/RemoveQualifiers.php
M extensions/Wikibase/repo/includes/Api/SetAliases.php
M extensions/Wikibase/repo/includes/Api/SetSiteLink.php
M extensions/Wikibase/repo/includes/ChangeOp/ChangeOpAliases.php
M extensions/Wikibase/repo/includes/ChangeOp/ChangeOpDescription.php
M extensions/Wikibase/repo/includes/ChangeOp/ChangeOpMainSnak.php
M extensions/Wikibase/repo/includes/ChangeOp/ChangeOpQualifier.php
M extensions/Wikibase/repo/includes/ChangeOp/ChangeOpQualifierRemove.php
M extensions/Wikibase/repo/includes/ChangeOp/ChangeOpReference.php
M extensions/Wikibase/repo/includes/ChangeOp/ChangeOpReferenceRemove.php
M extensions/Wikibase/repo/includes/ChangeOp/ChangeOpSiteLink.php
M extensions/Wikibase/repo/includes/ChangeOp/ChangeOpStatementRank.php
M extensions/Wikibase/repo/includes/MediaWikiLanguageDirectionalityLookup.php
M extensions/Wikibase/repo/includes/Parsers/MwTimeIsoParser.php
M extensions/Wikibase/repo/includes/Specials/SpecialNewProperty.php
M extensions/Wikibase/repo/includes/Store/Sql/EntityPerPageTable.php
M
extensions/Wikibase/repo/tests/phpunit/includes/Actions/ViewEntityActionTest.php
M extensions/Wikibase/repo/tests/phpunit/includes/EntityTypesTest.php
M
extensions/Wikibase/repo/tests/phpunit/includes/Specials/SpecialItemByTitleTest.php
M
extensions/Wikibase/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityStoreTest.php
M extensions/Wikibase/view/resources/wikibase/view/ViewFactory.js
M vendor/composer/installed.json
44 files changed, 113 insertions(+), 55 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikidata
refs/changes/94/329594/1
diff --git a/composer.lock b/composer.lock
index 90e6a18..7311cb0 100644
--- a/composer.lock
+++ b/composer.lock
@@ -1585,12 +1585,12 @@
"source": {
"type": "git",
"url":
"https://github.com/wikimedia/mediawiki-extensions-Wikibase.git";,
- "reference": "aeabf1549b026c49fdd872c1b066bd764357aa5b"
+ "reference": "54e002bd93d17b90ae5cb78b868a97a926c55c00"
},
"dist": {
"type": "zip",
- "url":
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/aeabf1549b026c49fdd872c1b066bd764357aa5b";,
- "reference": "aeabf1549b026c49fdd872c1b066bd764357aa5b",
+ "url":
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/54e002bd93d17b90ae5cb78b868a97a926c55c00";,
+ "reference": "54e002bd93d17b90ae5cb78b868a97a926c55c00",
"shasum": ""
},
"require": {
@@ -1663,7 +1663,7 @@
"wikibaserepo",
"wikidata"
],
- "time": "2016-12-26 21:42:40"
+ "time": "2016-12-29 09:25:42"
},
{
"name": "wikibase/wikimedia-badges",
diff --git a/extensions/Wikibase/client/i18n/atj.json
b/extensions/Wikibase/client/i18n/atj.json
index a7f406d..a40e888 100644
--- a/extensions/Wikibase/client/i18n/atj.json
+++ b/extensions/Wikibase/client/i18n/atj.json
@@ -8,6 +8,7 @@
"tooltip-t-wikibase": "Ite ke ispitatc",
"wikibase-dataitem": "{{WBREPONAME}} ka apatak",
"wikibase-editlinks": "Meckotona e ici tapitik",
+ "wikibase-editlinkstitle": "Meckotona e ici tapitik",
"wikibase-rc-hide-wikidata": "$1 {{WBREPONAME}}",
"wikibase-rc-wikibase-edit-letter": "D"
}
diff --git a/extensions/Wikibase/client/i18n/es.json
b/extensions/Wikibase/client/i18n/es.json
index d2b4ea3..ed371a2 100644
--- a/extensions/Wikibase/client/i18n/es.json
+++ b/extensions/Wikibase/client/i18n/es.json
@@ -95,7 +95,8 @@
"wikibase-pageswithbadges-legend": "Lista de páginas con un insignia
determinada",
"wikibase-pageswithbadges-badge": "Insignia:",
"wikibase-pageswithbadges-submit": "Mostrar páginas",
- "entityusage": "Uso de la entidad",
+ "entityusage": "Uso de entidades",
+ "entityusage-summary": "Esta página crea una lista de páginas que
utilizan una entidad dada (por ejemplo, Q42). La lista está ordenada por ID de
página de forma decreciente, con lo que las páginas más recientes estarán al
principio.",
"wikibase-entityusage-invalid-id": "$1 no es un identificador de
entidad válido",
"wikibase-entityusage-legend": "Lista de páginas que usan una
determinada entidad",
"wikibase-entityusage-entity": "Entidad:",
diff --git a/extensions/Wikibase/client/i18n/sty.json
b/extensions/Wikibase/client/i18n/sty.json
index 1363681..eb84e5c 100644
--- a/extensions/Wikibase/client/i18n/sty.json
+++ b/extensions/Wikibase/client/i18n/sty.json
@@ -9,6 +9,7 @@
"wikibase-dataitem": "{{WBREPONAME}}ның элементы",
"wikibase-editlinks": "Ссылкаларны төсәткәле",
"wikibase-editlinkstitle": "Пашҡа телләртәге ссылкаларны төсәткәле",
+ "wikibase-rc-hide-wikidata": "$1 {{WBREPONAME}}",
"wikibase-rc-wikibase-edit-letter": "D",
"wikibase-rc-wikibase-edit-title": "{{WBREPONAME}} төсәтеү"
}
diff --git a/extensions/Wikibase/client/includes/DispatchingServiceFactory.php
b/extensions/Wikibase/client/includes/DispatchingServiceFactory.php
index 59d857b..03d31cb 100644
--- a/extensions/Wikibase/client/includes/DispatchingServiceFactory.php
+++ b/extensions/Wikibase/client/includes/DispatchingServiceFactory.php
@@ -75,7 +75,11 @@
/**
* Returns a map of id prefix mappings defined for configured foreign
repositories.
- * @return array Associative array mapping repository names to
repository-specific prefix mapping
+ *
+ * @param array[] $settings
+ *
+ * @return array[] Associative array mapping repository names to
repository-specific prefix
+ * mapping.
*/
private function getIdPrefixMaps( array $settings ) {
$mappings = [];
diff --git
a/extensions/Wikibase/client/includes/Hooks/InterwikiSortingHookHandlers.php
b/extensions/Wikibase/client/includes/Hooks/InterwikiSortingHookHandlers.php
index a7319cf..c2736ad 100644
--- a/extensions/Wikibase/client/includes/Hooks/InterwikiSortingHookHandlers.php
+++ b/extensions/Wikibase/client/includes/Hooks/InterwikiSortingHookHandlers.php
@@ -36,7 +36,7 @@
private $alwaysSort;
/**
- * @return InterwikiSortingConfig
+ * @return self
*/
public static function newFromGlobalState() {
$wikibaseClient = WikibaseClient::getDefaultInstance();
@@ -57,7 +57,7 @@
* @param Config $config
* @param NamespaceChecker $namespaceChecker
*
- * @return InterwikiSortingHookHandlers
+ * @return self
*/
public static function newFromInterwikiSortingConfig(
Config $config,
@@ -69,7 +69,7 @@
$config->get( 'InterwikiSortingSortPrepend' )
);
- return new InterwikiSortingHookHandlers(
+ return new self(
$interwikiSorter,
$namespaceChecker,
$config->get( 'InterwikiSortingAlwaysSort' )
@@ -80,7 +80,7 @@
* @param SettingsArray $settings
* @param NamespaceChecker $namespaceChecker
*
- * @return InterwikiSortingHookHandlers
+ * @return self
*/
public static function newFromWikibaseConfig(
SettingsArray $settings,
@@ -92,7 +92,7 @@
$settings->getSetting( 'sortPrepend' )
);
- return new InterwikiSortingHookHandlers(
+ return new self(
$interwikiSorter,
$namespaceChecker,
$settings->getSetting( 'alwaysSort' )
diff --git
a/extensions/Wikibase/client/includes/Notifications/PageConnectionPresentationModel.php
b/extensions/Wikibase/client/includes/Notifications/PageConnectionPresentationModel.php
index bfa33dc..2d34b9a 100644
---
a/extensions/Wikibase/client/includes/Notifications/PageConnectionPresentationModel.php
+++
b/extensions/Wikibase/client/includes/Notifications/PageConnectionPresentationModel.php
@@ -18,7 +18,8 @@
class PageConnectionPresentationModel extends EchoEventPresentationModel {
/**
- * @param EchoEvent
+ * @param EchoEvent $event
+ *
* @return string
*/
public function callbackForBundleCount( EchoEvent $event ) {
diff --git
a/extensions/Wikibase/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseEntityLibraryTest.php
b/extensions/Wikibase/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseEntityLibraryTest.php
index e85cfca..06bf2d3 100644
---
a/extensions/Wikibase/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseEntityLibraryTest.php
+++
b/extensions/Wikibase/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseEntityLibraryTest.php
@@ -232,7 +232,7 @@
* @param bool &$cacheSplit Will become true when the ParserCache has
been split
* @param Language|null $userLang The user's language
*
- * @return Scribunto_LuaWikibaseLibrary
+ * @return Scribunto_LuaWikibaseEntityLibrary
*/
private function newScribuntoLuaWikibaseLibrary( &$cacheSplit = false,
Language $userLang = null ) {
/* @var $engine Scribunto_LuaEngine */
diff --git
a/extensions/Wikibase/client/tests/phpunit/includes/DispatchingServiceWiringTest.php
b/extensions/Wikibase/client/tests/phpunit/includes/DispatchingServiceWiringTest.php
index 0bca974..fc539ad 100644
---
a/extensions/Wikibase/client/tests/phpunit/includes/DispatchingServiceWiringTest.php
+++
b/extensions/Wikibase/client/tests/phpunit/includes/DispatchingServiceWiringTest.php
@@ -8,8 +8,6 @@
use Wikibase\Lib\Store\EntityRevisionLookup;
/**
- * @covers client/includes/DispatchingServiceWiring.php
- *
* @group Wikibase
* @group WikibaseClient
*
diff --git
a/extensions/Wikibase/client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php
b/extensions/Wikibase/client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php
index 729e370..df5633d 100644
---
a/extensions/Wikibase/client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php
+++
b/extensions/Wikibase/client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php
@@ -5,6 +5,7 @@
use EchoEvent;
use MediaWikiTestCase;
use Title;
+use Wikibase\ChangeRow;
use Wikibase\Client\Hooks\EchoNotificationsHandlers;
use Wikibase\Client\RepoLinker;
use Wikibase\Lib\Tests\Changes\TestChanges;
diff --git
a/extensions/Wikibase/client/tests/phpunit/includes/Store/RepositoryServiceWiringTest.php
b/extensions/Wikibase/client/tests/phpunit/includes/Store/RepositoryServiceWiringTest.php
index 2a4efed..ee4dc3b 100644
---
a/extensions/Wikibase/client/tests/phpunit/includes/Store/RepositoryServiceWiringTest.php
+++
b/extensions/Wikibase/client/tests/phpunit/includes/Store/RepositoryServiceWiringTest.php
@@ -11,8 +11,6 @@
use Wikibase\TermIndex;
/**
- * @covers client/includes/Store/RepositoryServiceWiring.php
- *
* @group Wikibase
* @group WikibaseClient
*
diff --git a/extensions/Wikibase/lib/includes/Store/PropertyInfoLookup.php
b/extensions/Wikibase/lib/includes/Store/PropertyInfoLookup.php
index ce81897..79330fd 100644
--- a/extensions/Wikibase/lib/includes/Store/PropertyInfoLookup.php
+++ b/extensions/Wikibase/lib/includes/Store/PropertyInfoLookup.php
@@ -2,6 +2,7 @@
namespace Wikibase\Lib\Store;
+use DBError;
use Wikibase\DataModel\Entity\PropertyId;
/**
diff --git
a/extensions/Wikibase/lib/includes/Store/Sql/SqlEntityInfoBuilder.php
b/extensions/Wikibase/lib/includes/Store/Sql/SqlEntityInfoBuilder.php
index 468d903..aef2797 100644
--- a/extensions/Wikibase/lib/includes/Store/Sql/SqlEntityInfoBuilder.php
+++ b/extensions/Wikibase/lib/includes/Store/Sql/SqlEntityInfoBuilder.php
@@ -512,6 +512,8 @@
/**
* @see EntityInfoBuilder::removeMissing
+ *
+ * @param string $redirects A flag, either "keep-redirects" (default)
or "remove-redirects".
*/
public function removeMissing( $redirects = 'keep-redirects' ) {
$missingIds = $this->getMissingIds( $redirects !==
'keep-redirects' );
diff --git a/extensions/Wikibase/lib/tests/phpunit/EntityTypesTest.php
b/extensions/Wikibase/lib/tests/phpunit/EntityTypesTest.php
index 1b49cc7..f9f28d7 100644
--- a/extensions/Wikibase/lib/tests/phpunit/EntityTypesTest.php
+++ b/extensions/Wikibase/lib/tests/phpunit/EntityTypesTest.php
@@ -9,8 +9,6 @@
use Wikibase\DataModel\SerializerFactory;
/**
- * @covers WikibaseLib.entitytypes.php
- *
* @group Wikibase
* @group WikibaseLib
*
diff --git
a/extensions/Wikibase/lib/tests/phpunit/Formatters/CommonsThumbnailFormatterTest.php
b/extensions/Wikibase/lib/tests/phpunit/Formatters/CommonsThumbnailFormatterTest.php
index 954a6ec..d39d378 100644
---
a/extensions/Wikibase/lib/tests/phpunit/Formatters/CommonsThumbnailFormatterTest.php
+++
b/extensions/Wikibase/lib/tests/phpunit/Formatters/CommonsThumbnailFormatterTest.php
@@ -9,7 +9,7 @@
use Wikibase\Lib\Formatters\CommonsThumbnailFormatter;
/**
- * @covers Wikibase\Lib\CommonsThumbnailFormatter
+ * @covers Wikibase\Lib\Formatters\CommonsThumbnailFormatter
*
* @group ValueFormatters
* @group WikibaseLib
diff --git
a/extensions/Wikibase/lib/tests/phpunit/Store/DispatchingTermBufferTest.php
b/extensions/Wikibase/lib/tests/phpunit/Store/DispatchingTermBufferTest.php
index b678195..17146f6 100644
--- a/extensions/Wikibase/lib/tests/phpunit/Store/DispatchingTermBufferTest.php
+++ b/extensions/Wikibase/lib/tests/phpunit/Store/DispatchingTermBufferTest.php
@@ -10,7 +10,7 @@
use Wikimedia\Assert\ParameterAssertionException;
/**
- * @covers Wikibase\Store\DispatchingTermBuffer
+ * @covers Wikibase\Lib\Store\DispatchingTermBuffer
*
* @group Wikibase
* @group WikibaseLib
diff --git
a/extensions/Wikibase/lib/tests/phpunit/Store/HttpUrlPropertyOrderProviderTest.php
b/extensions/Wikibase/lib/tests/phpunit/Store/HttpUrlPropertyOrderProviderTest.php
index fe89afa..80e4795 100644
---
a/extensions/Wikibase/lib/tests/phpunit/Store/HttpUrlPropertyOrderProviderTest.php
+++
b/extensions/Wikibase/lib/tests/phpunit/Store/HttpUrlPropertyOrderProviderTest.php
@@ -6,7 +6,7 @@
use Wikibase\Lib\Store\HttpUrlPropertyOrderProvider;
/**
- * @covers Wikibase\Store\HttpUrlPropertyOrderProvider
+ * @covers Wikibase\Lib\Store\HttpUrlPropertyOrderProvider
*
* @group Wikibase
* @group WikibaseLib
diff --git
a/extensions/Wikibase/lib/tests/phpunit/Store/MockPropertyInfoStoreTest.php
b/extensions/Wikibase/lib/tests/phpunit/Store/MockPropertyInfoStoreTest.php
index 51195de..0e7ceae 100644
--- a/extensions/Wikibase/lib/tests/phpunit/Store/MockPropertyInfoStoreTest.php
+++ b/extensions/Wikibase/lib/tests/phpunit/Store/MockPropertyInfoStoreTest.php
@@ -5,7 +5,7 @@
use Wikibase\DataModel\Entity\PropertyId;
/**
- * @covers Wikibase\Test\MockPropertyInfoStore
+ * @covers Wikibase\Lib\Tests\Store\MockPropertyInfoStore
*
* @since 0.4
*
diff --git
a/extensions/Wikibase/lib/tests/phpunit/Store/WikiPagePropertyOrderProviderTest.php
b/extensions/Wikibase/lib/tests/phpunit/Store/WikiPagePropertyOrderProviderTest.php
index bf5b5c1..5d74762 100644
---
a/extensions/Wikibase/lib/tests/phpunit/Store/WikiPagePropertyOrderProviderTest.php
+++
b/extensions/Wikibase/lib/tests/phpunit/Store/WikiPagePropertyOrderProviderTest.php
@@ -9,7 +9,7 @@
use MediaWikiTestCase;
/**
- * @covers Wikibase\Store\WikiPagePropertyOrderProvider
+ * @covers Wikibase\Lib\Store\WikiPagePropertyOrderProvider
* @group Wikibase
* @group WikibaseLib
* @group Database
diff --git a/extensions/Wikibase/lib/tests/phpunit/Units/UnitStorageTest.php
b/extensions/Wikibase/lib/tests/phpunit/Units/UnitStorageTest.php
index 38224b1..98f9664 100644
--- a/extensions/Wikibase/lib/tests/phpunit/Units/UnitStorageTest.php
+++ b/extensions/Wikibase/lib/tests/phpunit/Units/UnitStorageTest.php
@@ -10,7 +10,9 @@
use RuntimeException;
/**
- * @covers \Wikibase\Lib\UnitConverter
+ * @covers Wikibase\Lib\JsonUnitStorage
+ * @covers Wikibase\Lib\CSVUnitStorage
+ * @covers Wikibase\Lib\BaseUnitStorage
*
* @group Wikibase
*
diff --git a/extensions/Wikibase/repo/i18n/lb.json
b/extensions/Wikibase/repo/i18n/lb.json
index fc325a5..b7e599f 100644
--- a/extensions/Wikibase/repo/i18n/lb.json
+++ b/extensions/Wikibase/repo/i18n/lb.json
@@ -165,6 +165,7 @@
"wikibase-mergeitems-toid": "D'ID op déi zesummegeluecht gëtt",
"wikibase-mergeitems-submit": "Elementer zesummeleeën",
"wikibase-mergeitems-success": "$1 gouf mat $3 zesummegeluecht a
virugeleet.",
+ "wikibase-itemmerge-redirect": "Dës Elementer sinn eventuell scho
fusionéiert.",
"wikibase-itemmerge-failed-save": "D'Element konnt net gespäichert
ginn.",
"wikibase-itemmerge-permissiondenied": "Autorisatioun refuséiert",
"wikibase-itemmerge-no-such-entity": "Element gouf net fonnt.",
diff --git a/extensions/Wikibase/repo/i18n/zh-hans.json
b/extensions/Wikibase/repo/i18n/zh-hans.json
index f40dd31..adb9088 100644
--- a/extensions/Wikibase/repo/i18n/zh-hans.json
+++ b/extensions/Wikibase/repo/i18n/zh-hans.json
@@ -576,7 +576,7 @@
"apihelp-wbsetlabel-param-bot":
"将此编辑标记为机器人编辑。此URL标记将只在用户属于“bot”用户组时受尊重。",
"apihelp-wbsetlabel-param-language": "标签语言",
"apihelp-wbsetlabel-param-value": "标签值",
- "apihelp-wbsetlabel-example-1":
"为ID为“Q42”的页面设置字符串“Wikimedia”作为英语标签，并报告它为漂亮打印的json",
+ "apihelp-wbsetlabel-example-1":
"为ID为“Q42”的页面设置字符串“Wikimedia”作为英语标签，并报告它为优质打印的JSON。",
"apihelp-wbsetlabel-example-2": "为带有英语维基 => \"Earth\"的项设置英语标签为“Earth”。",
"apihelp-wbsetqualifier-description": "创建一个限定符或设置现有限定符的值。",
"apihelp-wbsetqualifier-param-claim": "识别用于已在标识符中设置的声明的GUID",
diff --git a/extensions/Wikibase/repo/includes/Api/RemoveQualifiers.php
b/extensions/Wikibase/repo/includes/Api/RemoveQualifiers.php
index f678d0c..9d9e51b 100644
--- a/extensions/Wikibase/repo/includes/Api/RemoveQualifiers.php
+++ b/extensions/Wikibase/repo/includes/Api/RemoveQualifiers.php
@@ -113,7 +113,9 @@
}
/**
- * Check the provided parameters
+ * @param array $params
+ *
+ * @throws ApiUsageException
*/
private function validateParameters( array $params ) {
if ( !( $this->modificationHelper->validateStatementGuid(
$params['claim'] ) ) ) {
diff --git a/extensions/Wikibase/repo/includes/Api/SetAliases.php
b/extensions/Wikibase/repo/includes/Api/SetAliases.php
index 43f5062..07bf2bf 100644
--- a/extensions/Wikibase/repo/includes/Api/SetAliases.php
+++ b/extensions/Wikibase/repo/includes/Api/SetAliases.php
@@ -77,6 +77,10 @@
/**
* @see ModifyEntity::validateParameters
+ *
+ * @param array $params
+ *
+ * @throws ApiUsageException
*/
protected function validateParameters( array $params ) {
parent::validateParameters( $params );
diff --git a/extensions/Wikibase/repo/includes/Api/SetSiteLink.php
b/extensions/Wikibase/repo/includes/Api/SetSiteLink.php
index d475bcc..9b8b30d 100644
--- a/extensions/Wikibase/repo/includes/Api/SetSiteLink.php
+++ b/extensions/Wikibase/repo/includes/Api/SetSiteLink.php
@@ -79,23 +79,6 @@
}
/**
- * @see ModifyEntity::getEntityRevisionFromApiParams
- */
- protected function getEntityRevisionFromApiParams( array $params ) {
- $entityRev = parent::getEntityRevisionFromApiParams( $params );
-
- // If we found anything then check if it is of the correct base
class
- if ( !is_null( $entityRev ) && !( $entityRev->getEntity()
instanceof Item ) ) {
- $this->errorReporter->dieError(
- 'The content on the found page is not of
correct type',
- 'wrong-class'
- );
- }
-
- return $entityRev;
- }
-
- /**
* @see ModifyEntity::modifyEntity
*/
protected function modifyEntity( EntityDocument &$entity, array
$params, $baseRevId ) {
diff --git a/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpAliases.php
b/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpAliases.php
index 993617a..bf64e17 100644
--- a/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpAliases.php
+++ b/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpAliases.php
@@ -100,6 +100,12 @@
/**
* @see ChangeOp::apply()
+ *
+ * @param EntityDocument $entity
+ * @param Summary|null $summary
+ *
+ * @throws InvalidArgumentException
+ * @throws ChangeOpException
*/
public function apply( EntityDocument $entity, Summary $summary = null
) {
if ( !( $entity instanceof AliasesProvider ) ) {
diff --git a/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpDescription.php
b/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpDescription.php
index 5f0eae7..032e9f7 100644
--- a/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpDescription.php
+++ b/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpDescription.php
@@ -76,6 +76,12 @@
/**
* @see ChangeOp::apply()
+ *
+ * @param EntityDocument $entity
+ * @param Summary|null $summary
+ *
+ * @throws InvalidArgumentException
+ * @throws ChangeOpException
*/
public function apply( EntityDocument $entity, Summary $summary = null
) {
if ( !( $entity instanceof DescriptionsProvider ) ) {
diff --git a/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpMainSnak.php
b/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpMainSnak.php
index 8238c48..8ca823d 100644
--- a/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpMainSnak.php
+++ b/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpMainSnak.php
@@ -84,6 +84,12 @@
* @see ChangeOp::apply()
* - a new claim with $snak as mainsnak gets added when $claimGuid is
empty and $snak is set
* - the claim's mainsnak gets set to $snak when $claimGuid and $snak
are set
+ *
+ * @param EntityDocument $entity
+ * @param Summary|null $summary
+ *
+ * @throws InvalidArgumentException
+ * @throws ChangeOpException
*/
public function apply( EntityDocument $entity, Summary $summary = null
) {
if ( !( $entity instanceof StatementListProvider ) ) {
diff --git a/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpQualifier.php
b/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpQualifier.php
index e8d809f..0d41bf7 100644
--- a/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpQualifier.php
+++ b/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpQualifier.php
@@ -73,6 +73,12 @@
* @see ChangeOp::apply()
* - a new qualifier gets added when $snakHash is empty and $snak is set
* - the qualifier gets set to $snak when $snakHash and $snak are set
+ *
+ * @param EntityDocument $entity
+ * @param Summary|null $summary
+ *
+ * @throws InvalidArgumentException
+ * @throws ChangeOpException
*/
public function apply( EntityDocument $entity, Summary $summary = null
) {
if ( !( $entity instanceof StatementListProvider ) ) {
diff --git
a/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpQualifierRemove.php
b/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpQualifierRemove.php
index 492ad95..5618da4 100644
--- a/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpQualifierRemove.php
+++ b/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpQualifierRemove.php
@@ -55,6 +55,12 @@
/**
* @see ChangeOp::apply()
+ *
+ * @param EntityDocument $entity
+ * @param Summary|null $summary
+ *
+ * @throws InvalidArgumentException
+ * @throws ChangeOpException
*/
public function apply( EntityDocument $entity, Summary $summary = null
) {
if ( !( $entity instanceof StatementListProvider ) ) {
diff --git a/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpReference.php
b/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpReference.php
index 7a2efbd..0affc78 100644
--- a/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpReference.php
+++ b/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpReference.php
@@ -95,6 +95,12 @@
* @see ChangeOp::apply()
* - a new reference gets added when $referenceHash is empty and
$reference is set
* - the reference gets set to $reference when $referenceHash and
$reference are set
+ *
+ * @param EntityDocument $entity
+ * @param Summary|null $summary
+ *
+ * @throws InvalidArgumentException
+ * @throws ChangeOpException
*/
public function apply( EntityDocument $entity, Summary $summary = null
) {
if ( !( $entity instanceof StatementListProvider ) ) {
diff --git
a/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpReferenceRemove.php
b/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpReferenceRemove.php
index 288b7d7..647a614 100644
--- a/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpReferenceRemove.php
+++ b/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpReferenceRemove.php
@@ -55,6 +55,12 @@
/**
* @see ChangeOp::apply()
+ *
+ * @param EntityDocument $entity
+ * @param Summary|null $summary
+ *
+ * @throws InvalidArgumentException
+ * @throws ChangeOpException
*/
public function apply( EntityDocument $entity, Summary $summary = null
) {
if ( !( $entity instanceof StatementListProvider ) ) {
diff --git a/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpSiteLink.php
b/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpSiteLink.php
index 340b7b7..2bc5dd4 100644
--- a/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpSiteLink.php
+++ b/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpSiteLink.php
@@ -129,6 +129,11 @@
/**
* @see ChangeOp::apply
+ *
+ * @param EntityDocument $entity
+ * @param Summary|null $summary
+ *
+ * @throws InvalidArgumentException
*/
public function apply( EntityDocument $entity, Summary $summary = null
) {
if ( !( $entity instanceof Item ) ) {
diff --git
a/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpStatementRank.php
b/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpStatementRank.php
index 6b02cb3..dff60d7 100644
--- a/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpStatementRank.php
+++ b/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpStatementRank.php
@@ -55,6 +55,12 @@
/**
* @see ChangeOp::apply()
+ *
+ * @param EntityDocument $entity
+ * @param Summary|null $summary
+ *
+ * @throws InvalidArgumentException
+ * @throws ChangeOpException
*/
public function apply( EntityDocument $entity, Summary $summary = null
) {
if ( !( $entity instanceof StatementListProvider ) ) {
diff --git
a/extensions/Wikibase/repo/includes/MediaWikiLanguageDirectionalityLookup.php
b/extensions/Wikibase/repo/includes/MediaWikiLanguageDirectionalityLookup.php
index cf582f8..fa74c75 100644
---
a/extensions/Wikibase/repo/includes/MediaWikiLanguageDirectionalityLookup.php
+++
b/extensions/Wikibase/repo/includes/MediaWikiLanguageDirectionalityLookup.php
@@ -18,6 +18,10 @@
/**
* @see LanguageDirectionalityLookup::getDirectionality
+ *
+ * @param string $languageCode
+ *
+ * @return string|null 'ltr', 'rtl' or null if unknown
*/
public function getDirectionality( $languageCode ) {
return Language::factory( $languageCode )->getDir();
diff --git a/extensions/Wikibase/repo/includes/Parsers/MwTimeIsoParser.php
b/extensions/Wikibase/repo/includes/Parsers/MwTimeIsoParser.php
index 04ace74..532d55a 100644
--- a/extensions/Wikibase/repo/includes/Parsers/MwTimeIsoParser.php
+++ b/extensions/Wikibase/repo/includes/Parsers/MwTimeIsoParser.php
@@ -77,6 +77,8 @@
/**
* @see StringValueParser::__construct
+ *
+ * @param ParserOptions|null $options
*/
public function __construct( ParserOptions $options = null ) {
parent::__construct( $options );
diff --git a/extensions/Wikibase/repo/includes/Specials/SpecialNewProperty.php
b/extensions/Wikibase/repo/includes/Specials/SpecialNewProperty.php
index c068196..8c8e1cf 100644
--- a/extensions/Wikibase/repo/includes/Specials/SpecialNewProperty.php
+++ b/extensions/Wikibase/repo/includes/Specials/SpecialNewProperty.php
@@ -54,6 +54,8 @@
}
/**
+ * @param string $dataType
+ *
* @return bool
*/
private function dataTypeExists( $dataType ) {
diff --git a/extensions/Wikibase/repo/includes/Store/Sql/EntityPerPageTable.php
b/extensions/Wikibase/repo/includes/Store/Sql/EntityPerPageTable.php
index 4eecffc..39a2ad8 100644
--- a/extensions/Wikibase/repo/includes/Store/Sql/EntityPerPageTable.php
+++ b/extensions/Wikibase/repo/includes/Store/Sql/EntityPerPageTable.php
@@ -35,7 +35,6 @@
/**
* @param LoadBalancer $loadBalancer
* @param EntityIdParser $entityIdParser
- * @param EntityIdComposer $entityIdComposer
*/
public function __construct(
LoadBalancer $loadBalancer,
diff --git
a/extensions/Wikibase/repo/tests/phpunit/includes/Actions/ViewEntityActionTest.php
b/extensions/Wikibase/repo/tests/phpunit/includes/Actions/ViewEntityActionTest.php
index e2e805e..85a1e8f 100644
---
a/extensions/Wikibase/repo/tests/phpunit/includes/Actions/ViewEntityActionTest.php
+++
b/extensions/Wikibase/repo/tests/phpunit/includes/Actions/ViewEntityActionTest.php
@@ -111,7 +111,7 @@
}
/**
- * @covers ViewEntityAction::onBeforeDisplayNoArticleText
+ * @covers \Wikibase\ViewEntityAction::onBeforeDisplayNoArticleText
*/
public function testShow404() {
$id = new ItemId( 'q1122334455' );
diff --git
a/extensions/Wikibase/repo/tests/phpunit/includes/EntityTypesTest.php
b/extensions/Wikibase/repo/tests/phpunit/includes/EntityTypesTest.php
index 457a385..f979869 100644
--- a/extensions/Wikibase/repo/tests/phpunit/includes/EntityTypesTest.php
+++ b/extensions/Wikibase/repo/tests/phpunit/includes/EntityTypesTest.php
@@ -11,8 +11,6 @@
use Wikibase\View\EntityView;
/**
- * @covers WikibaseRepo.entitytypes.php
- *
* @group Wikibase
* @group WikibaseRepo
*
diff --git
a/extensions/Wikibase/repo/tests/phpunit/includes/Specials/SpecialItemByTitleTest.php
b/extensions/Wikibase/repo/tests/phpunit/includes/Specials/SpecialItemByTitleTest.php
index 4311aef..a1ba284 100644
---
a/extensions/Wikibase/repo/tests/phpunit/includes/Specials/SpecialItemByTitleTest.php
+++
b/extensions/Wikibase/repo/tests/phpunit/includes/Specials/SpecialItemByTitleTest.php
@@ -7,6 +7,7 @@
use SiteLookup;
use SpecialPageTestBase;
use Title;
+use WebResponse;
use Wikibase\DataModel\Entity\EntityId;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\Lib\LanguageNameLookup;
@@ -187,13 +188,13 @@
* @dataProvider requestProvider
*/
public function testExecute( $sub, $target, array $matchers ) {
- /* @var FauxResponse $response */
+ /* @var WebResponse $response */
list( $output, $response ) = $this->executeSpecialPage( $sub );
if ( $target !== null ) {
$target = Title::newFromText( $target )->getFullURL();
$expected = wfExpandUrl( $target, PROTO_CURRENT );
- $this->assertEquals( $expected, $response->getheader(
'Location' ), 'Redirect' );
+ $this->assertEquals( $expected, $response->getHeader(
'Location' ), 'Redirect' );
}
foreach ( $matchers as $key => $matcher ) {
diff --git
a/extensions/Wikibase/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityStoreTest.php
b/extensions/Wikibase/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityStoreTest.php
index 3f48449..1b6c466 100644
---
a/extensions/Wikibase/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityStoreTest.php
+++
b/extensions/Wikibase/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityStoreTest.php
@@ -645,7 +645,7 @@
/**
* @dataProvider provideCanCreateWithCustomId
- * @covers WikiPageEntityStore::canCreateWithCustomId()
+ * @covers
\Wikibase\Repo\Store\WikiPageEntityStore::canCreateWithCustomId
*/
public function testCanCreateWithCustomId( EntityId $id, $expected ) {
/* @var WikiPageEntityStore $store */
diff --git a/extensions/Wikibase/view/resources/wikibase/view/ViewFactory.js
b/extensions/Wikibase/view/resources/wikibase/view/ViewFactory.js
index f5cd926..d468412 100644
--- a/extensions/Wikibase/view/resources/wikibase/view/ViewFactory.js
+++ b/extensions/Wikibase/view/resources/wikibase/view/ViewFactory.js
@@ -577,6 +577,7 @@
* @param {Object} options An object with keys `locked` and
`autoStartEditing`
* @param {wikibase.datamodel.Snak|null} snak
* @param {jQuery} $snakview
+ * @param {Function} removeCallback
* @return {jQuery.wikibase.snakview} The constructed snakview
*/
SELF.prototype.getSnakView = function( startEditingCallback,
drawProperty, options, snak, $snakview, removeCallback ) {
diff --git a/vendor/composer/installed.json b/vendor/composer/installed.json
index 00096e7..ae858fe 100644
--- a/vendor/composer/installed.json
+++ b/vendor/composer/installed.json
@@ -1406,12 +1406,12 @@
"source": {
"type": "git",
"url":
"https://github.com/wikimedia/mediawiki-extensions-Wikibase.git";,
- "reference": "aeabf1549b026c49fdd872c1b066bd764357aa5b"
+ "reference": "54e002bd93d17b90ae5cb78b868a97a926c55c00"
},
"dist": {
"type": "zip",
- "url":
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/aeabf1549b026c49fdd872c1b066bd764357aa5b";,
- "reference": "aeabf1549b026c49fdd872c1b066bd764357aa5b",
+ "url":
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/54e002bd93d17b90ae5cb78b868a97a926c55c00";,
+ "reference": "54e002bd93d17b90ae5cb78b868a97a926c55c00",
"shasum": ""
},
"require": {
@@ -1444,7 +1444,7 @@
"jakub-onderka/php-parallel-lint": "0.9.2",
"mediawiki/mediawiki-codesniffer": "0.4.0|0.5.0"
},
- "time": "2016-12-26 21:42:40",
+ "time": "2016-12-29 09:25:42",
"type": "mediawiki-extension",
"installation-source": "dist",
"autoload": {
--
To view, visit https://gerrit.wikimedia.org/r/329594
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c62e28dd551d2d4a98332eaae1f3af1480010e1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikidata
Gerrit-Branch: master
Gerrit-Owner: WikidataBuilder <wikidata-servi...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
