jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/329679 )
Change subject: Add ->text() to prevent double HTML escaping ...................................................................... Add ->text() to prevent double HTML escaping wfMessage() without ->text() makes an automatic HTML escaping. Html::element() makes also a HTML escaping of the content. This leads to a double escaping and raw HTML in shown on the rendered page. Change-Id: I68165492c828837f842e7885f557644ca1bb0a8c --- M includes/specials/SpecialChangeCredentials.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Bartosz Dziewoński: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/specials/SpecialChangeCredentials.php b/includes/specials/SpecialChangeCredentials.php index ff70848..f22d5f3 100644 --- a/includes/specials/SpecialChangeCredentials.php +++ b/includes/specials/SpecialChangeCredentials.php @@ -135,9 +135,9 @@ $form->addPreText( Html::openElement( 'dl' ) - . Html::element( 'dt', [], wfMessage( 'credentialsform-provider' ) ) + . Html::element( 'dt', [], wfMessage( 'credentialsform-provider' )->text() ) . Html::element( 'dd', [], $info['provider'] ) - . Html::element( 'dt', [], wfMessage( 'credentialsform-account' ) ) + . Html::element( 'dt', [], wfMessage( 'credentialsform-account' )->text() ) . Html::element( 'dd', [], $info['account'] ) . Html::closeElement( 'dl' ) ); -- To view, visit https://gerrit.wikimedia.org/r/329679 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68165492c828837f842e7885f557644ca1bb0a8c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Fomafix <foma...@googlemail.com> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits