Seb35 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/329682 )

Change subject: Soft deprecation of DatabaseMysql
......................................................................

Soft deprecation of DatabaseMysql

This class is the driver for MySQL databases corresponding to the PHP
extension 'mysql'. This PHP extension was deprecated in PHP 5.5 and
removed in PHP 7.0. It was replaced by the PHP extension 'mysqli',
which is supported and the default MySQL driver since MediaWiki 1.22.

Bug: T120333
Change-Id: Id1478f73e348cdd1ad1f560b1d8ddefe56c52767
---
M RELEASE-NOTES-1.29
M includes/libs/rdbms/database/Database.php
M includes/libs/rdbms/database/DatabaseMysql.php
3 files changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/82/329682/1

diff --git a/RELEASE-NOTES-1.29 b/RELEASE-NOTES-1.29
index 774254c..c8a809a 100644
--- a/RELEASE-NOTES-1.29
+++ b/RELEASE-NOTES-1.29
@@ -147,6 +147,9 @@
 * User::getTemporaryPassword() (deprecated in 1.27) was removed.
 * User::isPasswordReminderThrottled() (deprecated in 1.27) was removed.
 * FSRepo (deprecated in 1.19) was removed.
+* (T120333) Soft-deprecated the use of PHP extension 'mysql' in favor of 
'mysqli'
+  (this PHP extension was deprecated in PHP 5.5 and removed in PHP 7.0;
+  MediaWiki auto-selects the 'mysqli' driver since MediaWiki 1.22).
 
 == Compatibility ==
 
diff --git a/includes/libs/rdbms/database/Database.php 
b/includes/libs/rdbms/database/Database.php
index 69cf1ac..6b47178 100644
--- a/includes/libs/rdbms/database/Database.php
+++ b/includes/libs/rdbms/database/Database.php
@@ -1975,7 +1975,7 @@
         * Quotes an identifier using `backticks` or "double quotes" depending 
on the database type.
         * MySQL uses `backticks` while basically everything else uses double 
quotes.
         * Since MySQL is the odd one out here the double quotes are our generic
-        * and we implement backticks in DatabaseMysql.
+        * and we implement backticks in DatabaseMysqlBase.
         *
         * @param string $s
         * @return string
diff --git a/includes/libs/rdbms/database/DatabaseMysql.php 
b/includes/libs/rdbms/database/DatabaseMysql.php
index 9ab7c64..2d70227 100644
--- a/includes/libs/rdbms/database/DatabaseMysql.php
+++ b/includes/libs/rdbms/database/DatabaseMysql.php
@@ -24,6 +24,7 @@
 /**
  * Database abstraction object for PHP extension mysql.
  *
+ * @deprecated 1.29:1.31 The PHP extension 'mysql' was deprecated in PHP 5.5 
and removed in PHP 7.0, it is replaced by the PHP extension 'mysqli'.
  * @ingroup Database
  * @see Database
  */

-- 
To view, visit https://gerrit.wikimedia.org/r/329682
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1478f73e348cdd1ad1f560b1d8ddefe56c52767
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Seb35 <seb35wikipe...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to