VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/329800 )

Change subject: Replace deprecated mediawiki.UI Less variables with current ones
......................................................................

Replace deprecated mediawiki.UI Less variables with current ones

Replacing variables, which have been deprecated since MW 1.24,
with fix color values for now. This is an intermediate step in
order to proceed with planned WMUI Base variables usage.
Also aligning code to CSS Coding Guidelines and making use of
`.box-sizing()` global Less mixin.

Bug: T154362
Change-Id: Idd90a4fa56d55f545f978dc68dd86adc0e77eb53
---
M styles/link.less
1 file changed, 15 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Kartographer 
refs/changes/00/329800/1

diff --git a/styles/link.less b/styles/link.less
index 25b346f..2f44edb 100644
--- a/styles/link.less
+++ b/styles/link.less
@@ -1,10 +1,9 @@
-@import 'mediawiki.ui/variables';
 @import 'mediawiki.mixins';
 
 /* stylelint-disable no-descending-specificity */
 .mw-kartographer-link,
 .mw-kartographer-maplink {
-       &::not(.mw-kartographer-map) {
+       &:not( .mw-kartographer-map ) {
                display: inline;
        }
        cursor: pointer;
@@ -13,8 +12,7 @@
 // The icon only applies to <a> types of `.mw-kartographer-link`
 .mw-kartographer-maplink,
 a.mw-kartographer-link {
-
-       
&:not(.mw-kartographer-autostyled):not(.mw-kartographer-map):not(.no-icon) {
+       &:not( .mw-kartographer-autostyled ):not( .mw-kartographer-map ):not( 
.no-icon ) {
                /**
                 * These two files were copied from OOjs UI repository after 
the build process
                 * generated the progressive icons.
@@ -24,7 +22,7 @@
                 * The master version of the icon is at:
                 *   
https://github.com/wikimedia/oojs-ui/blob/master/src/themes/mediawiki/images/icons/mapPin.svg
                 */
-               .background-image-svg('images/mapPin-progressive.svg', 
'images/mapPin-progressive.png');
+               .background-image-svg( 'images/mapPin-progressive.svg', 
'images/mapPin-progressive.png' );
                background-position: left -3px;
                background-repeat: no-repeat;
                background-size: 18px 18px;
@@ -43,10 +41,9 @@
 .skin-minerva {
        a.mw-kartographer-link,
        .mw-kartographer-maplink {
-
-               
&:not(.mw-kartographer-autostyled):not(.mw-kartographer-map):not(.no-icon) {
-                       padding-left: 20px;
+               &:not( .mw-kartographer-autostyled ):not( .mw-kartographer-map 
):not( .no-icon ) {
                        background-size: 20px 20px;
+                       padding-left: 20px;
                }
 
                // One can display an iconless link by adding `class="no-icon"`
@@ -60,10 +57,10 @@
 
 .mw-kartographer-map:hover {
        .mw-kartographer-fullScreen {
-               background-color: @colorWhite;
+               background-color: #fff;
        }
        .oo-ui-buttonElement-button {
-               background-color: @colorWhite;
+               background-color: #fff;
        }
 }
 
@@ -75,8 +72,8 @@
                cursor: pointer;
        }
 
-       .mw-kartographer-maplink:not(.mw-kartographer-link),
-               
.mw-kartographer-map:not(.mw-kartographer-link):not(.mw-kartographer-interactive)
 {
+       .mw-kartographer-maplink:not( .mw-kartographer-link ),
+               .mw-kartographer-map:not( .mw-kartographer-link ):not( 
.mw-kartographer-interactive ) { // stylelint bug
                pointer-events: none;
                cursor: default;
        }
@@ -86,26 +83,22 @@
  * If `$wgKartographerUseMarkerStyle = true`.
  */
 a.mw-kartographer-autostyled {
+       color: #fff;
        display: inline-block;
-
        position: relative;
        top: -0.08em;
-
-       box-sizing: content-box;
+       .box-sizing ( content-box );
        height: 0.85em;
-       border-radius: 1px;
-
        margin-left: 0;
+       border-radius: 1px;
        padding: 0.24em 0.42em;
-
-       color: @colorWhite;
        font-size: 0.85em;
        font-weight: bold;
        line-height: 1;
        text-align: center;
        vertical-align: middle;
-}
 
-a.mw-kartographer-autostyled:visited {
-       color: @colorWhite;
+       &:visited {
+               color: #fff;
+       }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/329800
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd90a4fa56d55f545f978dc68dd86adc0e77eb53
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to