Hashar has submitted this change and it was merged.
Change subject: whitelist files passed to phpcs-HEAD
......................................................................
whitelist files passed to phpcs-HEAD
Following f19432b, we were blacklisting files we do not want to pass to
phpcs (such as .css or .js). Turns out they are parsed nonetheless
since they are passed as arguments to the command.
This patch remove the blacklisting of .css .js and use whitelisting
instead. The files extensions that will be passed to phpcs-HEAD are:
.php .php5 .inc .sample
Change-Id: I9243ea41081cfacc5503f83408bbee829931ebe7
---
M macro.yaml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Hashar: Verified; Looks good to me, approved
diff --git a/macro.yaml b/macro.yaml
index 397aac2..3d5ccae 100644
--- a/macro.yaml
+++ b/macro.yaml
@@ -175,7 +175,7 @@
# handle. Piped to 'echo -n' to ignore egrep exit code.
PHPCS_FILES=$(git diff --name-status HEAD^ \
| egrep -v '^D' | cut -f2 \
- | egrep -v '\.(css|js)$' \
+ | egrep '\.(php5?|inc|sample)$' \
|| echo -n
)
# No file? No point in proceeding any further (bug 44567)
--
To view, visit https://gerrit.wikimedia.org/r/49618
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9243ea41081cfacc5503f83408bbee829931ebe7
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins-job-builder-config
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
