Muehlenhoff has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/328665 )
Change subject: eventbus: Restrict to domain networks
......................................................................
eventbus: Restrict to domain networks
We're getting rid of $INTERNAL, which is needlessly broad. Restrict
eventbus to $DOMAIN_NETWORKS, so that when running in production
access is restriced to production networks and when running in labs
to labs networks.
Change-Id: Ie9bcce8f47d1aac93e1c49684bddc67b88d29f88
---
M modules/role/manifests/eventbus/eventbus.pp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Muehlenhoff: Looks good to me, approved
Ottomata: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/modules/role/manifests/eventbus/eventbus.pp
b/modules/role/manifests/eventbus/eventbus.pp
index f96116c..1d1cc0a 100644
--- a/modules/role/manifests/eventbus/eventbus.pp
+++ b/modules/role/manifests/eventbus/eventbus.pp
@@ -107,7 +107,7 @@
ferm::service { 'eventlogging-service-eventbus':
proto => 'tcp',
port => '8085',
- srange => '$INTERNAL',
+ srange => '$DOMAIN_NETWORKS',
}
}
--
To view, visit https://gerrit.wikimedia.org/r/328665
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9bcce8f47d1aac93e1c49684bddc67b88d29f88
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff <mmuhlenh...@wikimedia.org>
Gerrit-Reviewer: Elukey <ltosc...@wikimedia.org>
Gerrit-Reviewer: Muehlenhoff <mmuhlenh...@wikimedia.org>
Gerrit-Reviewer: Ottomata <ao...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
