jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/322052 )
Change subject: FloatableElement: Replace superfluous class with general one
......................................................................
FloatableElement: Replace superfluous class with general one
Replacing `.oo-ui-floatableElement-hidden` with general
`.oo-ui-element-hidden` class.
Change-Id: Ied0159dbba5d68d41bb9cdeaf81bdcbd03ce8d0a
---
M src/mixins/FloatableElement.js
M src/styles/elements/FloatableElement.less
2 files changed, 2 insertions(+), 6 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, but someone else must approve
Prtksxna: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/mixins/FloatableElement.js b/src/mixins/FloatableElement.js
index 9da0d28..8fa82e5 100644
--- a/src/mixins/FloatableElement.js
+++ b/src/mixins/FloatableElement.js
@@ -177,10 +177,10 @@
}
if ( !this.isElementInViewport( this.$floatableContainer,
this.$floatableClosestScrollable ) ) {
- this.$floatable.addClass( 'oo-ui-floatableElement-hidden' );
+ this.$floatable.addClass( 'oo-ui-element-hidden' );
return;
} else {
- this.$floatable.removeClass( 'oo-ui-floatableElement-hidden' );
+ this.$floatable.removeClass( 'oo-ui-element-hidden' );
}
if ( !this.needsCustomPosition ) {
diff --git a/src/styles/elements/FloatableElement.less
b/src/styles/elements/FloatableElement.less
index 6abbf97..293f4fd 100644
--- a/src/styles/elements/FloatableElement.less
+++ b/src/styles/elements/FloatableElement.less
@@ -1,9 +1,5 @@
@import '../common';
.oo-ui-floatableElement {
- &-hidden {
- display: none;
- }
-
.theme-oo-ui-floatableElement();
}
--
To view, visit https://gerrit.wikimedia.org/r/322052
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied0159dbba5d68d41bb9cdeaf81bdcbd03ce8d0a
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Prtksxna <psax...@wikimedia.org>
Gerrit-Reviewer: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
