VitaliyFilippov has submitted this change and it was merged.
Change subject: Do not show lightboxes for skin images
......................................................................
Do not show lightboxes for skin images
This fixes duplicate lightboxes for [[File:Image.jpg|thumb]].
Change-Id: Idb7182767efce2ee05a336aef1937c448030755b
---
M SlimboxThumbs.php
M slimbox/slimboxthumbs.js
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
VitaliyFilippov: Verified; Looks good to me, approved
diff --git a/SlimboxThumbs.php b/SlimboxThumbs.php
index 779eabd..95afa9d 100644
--- a/SlimboxThumbs.php
+++ b/SlimboxThumbs.php
@@ -27,7 +27,7 @@
die( 'Not an entry point.' );
}
-define( 'SlimboxThumbs_VERSION', '2013-01-10' );
+define( 'SlimboxThumbs_VERSION', '2013-02-18' );
// Register the extension credits.
$wgExtensionCredits['other'][] = array(
diff --git a/slimbox/slimboxthumbs.js b/slimbox/slimboxthumbs.js
index d70116a..33cb700 100644
--- a/slimbox/slimboxthumbs.js
+++ b/slimbox/slimboxthumbs.js
@@ -6,6 +6,7 @@
function makeSlimboxThumbs( $, pathRegexp, wgFullScriptPath ) {
var re = new RegExp( pathRegexp );
+ var reExcl = /(^|\/)skins\//;
var canview = /\.(jpe?g|jpe|gif|png)$/i;
var m;
var names = [];
@@ -24,7 +25,7 @@
var ww = $( window ).width();
var wh = $( window ).height() * 0.9;
$( 'img' ).each( function( i, e ) {
- if ( e.parentNode.nodeName == 'A' && ( m =
re.exec( e.parentNode.href ) ) ) {
+ if ( e.parentNode.nodeName == 'A' && ( m =
re.exec( e.parentNode.href ) ) && !reExcl.exec( e.src ) ) {
var n = decodeURIComponent( m[1] );
if ( !r[n] ) {
return;
--
To view, visit https://gerrit.wikimedia.org/r/49645
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb7182767efce2ee05a336aef1937c448030755b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SlimboxThumbs
Gerrit-Branch: master
Gerrit-Owner: VitaliyFilippov <[email protected]>
Gerrit-Reviewer: VitaliyFilippov <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
