Daniel Kinzler has submitted this change and it was merged.
Change subject: (hotfix) Auto-comments: Show nothing rather than cryptic GUIDs.
......................................................................
(hotfix) Auto-comments: Show nothing rather than cryptic GUIDs.
Change-Id: I243f0d1c3d3e73501e73e9069186d6222b493a16
---
M repo/includes/api/ApiRemoveClaims.php
M repo/includes/api/ApiSetClaimValue.php
2 files changed, 8 insertions(+), 6 deletions(-)
Approvals:
Denny Vrandecic: Verified; Looks good to me, approved
Daniel Kinzler:
diff --git a/repo/includes/api/ApiRemoveClaims.php
b/repo/includes/api/ApiRemoveClaims.php
index 2e9e8d6..1b0da96 100644
--- a/repo/includes/api/ApiRemoveClaims.php
+++ b/repo/includes/api/ApiRemoveClaims.php
@@ -265,8 +265,9 @@
* @see ApiAutocomment::getTextForSummary()
*/
public function getTextForSummary( array $params ) {
- return Autocomment::formatAutoSummary(
- Autocomment::pickValuesFromParams( $params, 'claim' )
- );
+ // We should show the property ID or label here.
+ // The refactoring required for that is still pending.
+ // For now, we show nothing rather than cryptic GUIDs.
+ return array( 0, "", false );
}
}
diff --git a/repo/includes/api/ApiSetClaimValue.php
b/repo/includes/api/ApiSetClaimValue.php
index f592fd6..5a3fd4a 100644
--- a/repo/includes/api/ApiSetClaimValue.php
+++ b/repo/includes/api/ApiSetClaimValue.php
@@ -213,8 +213,9 @@
* @see ApiAutocomment::getTextForSummary()
*/
public function getTextForSummary( array $params ) {
- return Autocomment::formatAutoSummary(
- Autocomment::pickValuesFromParams( $params, 'claim' )
- );
+ // We should show the property ID or label here.
+ // The refactoring required for that is still pending.
+ // For now, we show nothing rather than cryptic GUIDs.
+ return array( 0, "", false );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/49644
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I243f0d1c3d3e73501e73e9069186d6222b493a16
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.21-wmf10
Gerrit-Owner: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Denny Vrandecic <[email protected]>
Gerrit-Reviewer: John Erling Blad <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
