Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330877 )
Change subject: DNM output unparsable input in phan postprocess
......................................................................
DNM output unparsable input in phan postprocess
Change-Id: I7bad162a58020ace7f0f18a9d4475106d9b92190
---
M tests/phan/bin/postprocess-phan.php
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/77/330877/1
diff --git a/tests/phan/bin/postprocess-phan.php
b/tests/phan/bin/postprocess-phan.php
index 3e80598..9705e458 100644
--- a/tests/phan/bin/postprocess-phan.php
+++ b/tests/phan/bin/postprocess-phan.php
@@ -66,7 +66,11 @@
*/
public function suppress( $input ) {
$dom = new DOMDocument();
- $dom->loadXML( $input );
+ $xmlLoadSuccess = $dom->loadXML( $input );
+ if ( !$xmlLoadSuccess ) {
+ throw new RuntimeException( 'Could not load XML from
input: "' . $input . '""' );
+ }
+
$hasErrors = false;
// DOMNodeList's are "live", convert to an array so it works as
expected
$files = [];
--
To view, visit https://gerrit.wikimedia.org/r/330877
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7bad162a58020ace7f0f18a9d4475106d9b92190
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
