jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/330873 )

Change subject: Fix missing href attribute in link dropdown button
......................................................................


Fix missing href attribute in link dropdown button

When hovering over the link dropdown button in the toolbar,
the cursor won't switch to hand because there is no link.

Change-Id: Ib490e658cbed23d8058e1d7ec22848c5ec9b37fd
---
M index.html
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Thiemo Mättig (WMDE): Looks good to me, approved



diff --git a/index.html b/index.html
index 3a9a340..00ea1e7 100644
--- a/index.html
+++ b/index.html
@@ -138,7 +138,7 @@
                                                                <li><a 
id="downloadCSV" href="#">CSV</a></li>
                                                        </ul></li>
                                                        <li>
-                                                       <a id="link-button" 
data-toggle="dropdown" class="dropdown-toggle" aria-haspopup="true" 
aria-expanded="false" data-placement="top" 
data-i18n="[title]wdqs-app-button-link-title">
+                                                       <a id="link-button" 
href="#" data-toggle="dropdown" class="dropdown-toggle" aria-haspopup="true" 
aria-expanded="false" data-placement="top" 
data-i18n="[title]wdqs-app-button-link-title">
                                                                    <span 
class="glyphicon glyphicon-link" aria-hidden="true"></span><span 
data-i18n="wdqs-app-button-link"></span><span class="caret"></span>
                                                                  </a>
                                                                  <ul 
class="dropdown-menu">

-- 
To view, visit https://gerrit.wikimedia.org/r/330873
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib490e658cbed23d8058e1d7ec22848c5ec9b37fd
Gerrit-PatchSet: 2
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Divadsn <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Divadsn <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to