Fomafix has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330916 )
Change subject: Replace $( document ).ready(...) by $(...) ...................................................................... Replace $( document ).ready(...) by $(...) In jQuery 3 $(document).ready(...) is deprecated. https://jquery.com/upgrade-guide/3.0/#deprecated-document-ready-handlers-other-than-jquery-function Change-Id: Iddec938b358388db11203b4b604928ecdcb3abe2 --- M resources/mmv/logging/mmv.logging.Logger.js M resources/mmv/mmv.bootstrap.autostart.js M resources/mmv/mmv.head.js 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer refs/changes/16/330916/1 diff --git a/resources/mmv/logging/mmv.logging.Logger.js b/resources/mmv/logging/mmv.logging.Logger.js index 855f16a..10bad51 100644 --- a/resources/mmv/logging/mmv.logging.Logger.js +++ b/resources/mmv/logging/mmv.logging.Logger.js @@ -73,7 +73,7 @@ waitForEventLog = $.Deferred(); // Waits for dom readiness because we don't want to have these dependencies loaded in the head - $( document ).ready( function () { + $( function () { // window.Geo is currently defined in components that are loaded independently, there is no cheap // way to load just that information. Either we piggy-back on something that already loaded it // or we just don't have it diff --git a/resources/mmv/mmv.bootstrap.autostart.js b/resources/mmv/mmv.bootstrap.autostart.js index 37e3cf9..7fde43f 100644 --- a/resources/mmv/mmv.bootstrap.autostart.js +++ b/resources/mmv/mmv.bootstrap.autostart.js @@ -26,7 +26,7 @@ bootstrap = new mw.mmv.MultimediaViewerBootstrap(); - $( document ).ready( function () { + $( function () { bootstrap.setupEventHandlers(); } ); diff --git a/resources/mmv/mmv.head.js b/resources/mmv/mmv.head.js index ce88dc5..22dc118 100644 --- a/resources/mmv/mmv.head.js +++ b/resources/mmv/mmv.head.js @@ -47,7 +47,7 @@ // We wait for document readiness because mw.loader.using writes to the DOM // which can cause a blank page if it happens before DOM readiness - $document.ready( function () { + $( function () { mw.loader.using( [ 'mmv.bootstrap.autostart' ], function () { mw.mmv.bootstrap.whenThumbsReady().then( function () { mw.mmv.durationLogger.stop( 'early-click-to-replay-click', start ).record( 'early-click-to-replay-click' ); -- To view, visit https://gerrit.wikimedia.org/r/330916 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iddec938b358388db11203b4b604928ecdcb3abe2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Fomafix <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
